November 2009 - developers-list

[Monetdb-developers] Bug- & Test- status assessment: Please help!
by Stefan Manegold 15 Nov '09

15 Nov '09

Dear fellow MonetDB developers, Dear MonetDB users, preparing for the upcming Nov2009 release we spent quite some time and efford in cleaning-up the "Stable" TestWeb ( cf., http://monetdb.cwi.nl/Development/TestWeb/Stable/ ) and fixing as many open bugs as possible. Big thansk go to all of you that were actively involved! To further assess the status of (failing) tests and in particular open bug reports ( cf., https://sourceforge.net/tracker/?words=tracker_browse&sort=priority&sortdir… ) I ask all of you to 1) check the open bugs submitted by you, https://sourceforge.net/tracker/?words=tracker_browse&sort=submitted_by&sor… a) whether there is a test in CVS for this bug or not; b) whether the problem still occurs, i.e., whether the test still fails, or whether the problem still occurs for you with the latest Nov2009 CVS code base. Please report any findings in detail via the bug tracker. 2) check the open bugs assigned to you https://sourceforge.net/tracker/?words=tracker_browse&sort=assigned_to&sort… a) whether there is a test in CVS for this bug or not; b) whether the problem still occurs, i.e., whether the test still fails, or whether the problem still occurs for you with the latest Nov2009 CVS code base. Please report any findings in detail via the bug tracker. 3) check all bug reports closed since Aug2009, whether they are (if applicable) backed-up by a test in CVS. 4) check all failing test in the TestWeb http://monetdb.cwi.nl/Development/TestWeb/Stable/ whether they are documented by a bug report. Thank you very much in advance! Stefan -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |

1 0

Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/tests/BugTracker/Tests function_parameter_without_type.SF-1898518.stable.err, Nov2009, 1.2, 1.2.8.1 function_parameter_without_type.SF-1898518.stable.out, Nov2009, 1.2, 1.2.8.1
by Martin Kersten 14 Nov '09

14 Nov '09

Stefan Manegold wrote: > Update of /cvsroot/monetdb/pathfinder/tests/BugTracker/Tests > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv5625 > > Modified Files: > Tag: Nov2009 > function_parameter_without_type.SF-1898518.stable.err > function_parameter_without_type.SF-1898518.stable.out > Log Message: > > approved error message of first version of the query > after Peter's "will not be fixed" verdict; ^^^^^^^^^^^^^^^^^^^^ Differentiate between errors that won't be fixed and feature requests. The latter belong to a different list.

1 0

Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal mal_mapi.mx, Nov2009, 1.37.2.3, 1.37.2.4
by Romulo Goncalves 11 Nov '09

11 Nov '09

Hello, One remark for a broken test in SQL. Fabian wrote: > Update of /cvsroot/monetdb/MonetDB5/src/modules/mal > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv27989 > > Modified Files: > Tag: Nov2009 > mal_mapi.mx > Log Message: > Free resources allocated for Mapi struct before returning. Found by Coverity. (I have no clue how to update this so it is recorded as handled in the Coverity webpage, someone please fill me in.) > > Index: mal_mapi.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/mal_mapi.mx,v > retrieving revision 1.37.2.3 > retrieving revision 1.37.2.4 > diff -u -d -r1.37.2.3 -r1.37.2.4 > --- mal_mapi.mx 30 Oct 2009 18:48:31 -0000 1.37.2.3 > +++ mal_mapi.mx 3 Nov 2009 18:27:14 -0000 1.37.2.4 > @@ -407,7 +407,7 @@ > bstream *bs; > int len = 0; > > - if ( buf == NULL){ > + if (buf == NULL){ > GDKsyserror("SERVERlisten:"MAL_MALLOC_FAIL); > return; > } > @@ -922,6 +922,7 @@ > if (err[0] == '!') > err = err + 1; > SERVERsessions[i].c = NULL; > + mapi_destroy(mid); You are freeing here mid, but err is dependent of it. Because the complete if clause is like this: if (mapi_error(mid)) { str err = mapi_error_str(mid); if (err == NULL) err = "(no reason given)"; if (err[0] == '!') err = err + 1; SERVERsessions[i].c = NULL; mapi_destroy(mid); throw(IO, "mapi.connect", "Could not connect: %s", err); } and mapi_error returns: 926 str err = mapi_error_str(mid); (gdb) s mapi_error_str (mid=0x1277af0) at /ufs/goncalve/MonetDB/stable/clients/src/mapilib/Mapi.mx:1352 1352 assert(mid); (gdb) n 1353 return mid->errorstr; (gdb) 1354 } This is the reason why connection is broken and gives the following error message: ERROR = !IOException:mapi.connect:Could not connect: `Ú¶08 instead of: ERROR = !IOException:mapi.connect:Could not connect: Setup connection failed Correct if I am wrong... Ro > throw(IO, "mapi.connect", "Could not connect: %s", err); > } > > > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

2 1

[Monetdb-developers] MonetDB PHP interface
by Stefan Manegold 10 Nov '09

10 Nov '09

Gabriele, is your new native PHP interface for MonetDB complete in the Nov2009 branch, and does it replace the old Cimpl-/SWIG-based one completely? If so, we should consider removing the old Cimpl-/SWIG-based PHP interface for MonetDB in the Nov2009 release ... Stefan -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |

2 1

Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal/crackers crackers_partial_sideways.mx, , 1.7, 1.8
by Martin Kersten 10 Nov '09

10 Nov '09

stratos wrote: > Update of /cvsroot/monetdb/MonetDB5/src/modules/mal/crackers > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv26417 > > Modified Files: > crackers_partial_sideways.mx > Log Message: > more safety checks from coverity > > > Index: crackers_partial_sideways.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/crackers/crackers_partial_sideways.mx,v > retrieving revision 1.7 > retrieving revision 1.8 > diff -u -d -r1.7 -r1.8 > --- crackers_partial_sideways.mx 9 Nov 2009 22:06:57 -0000 1.7 > +++ crackers_partial_sideways.mx 10 Nov 2009 00:05:34 -0000 1.8 > @@ -647,9 +647,9 @@ > oid i; > > if (nodeLow == NULL) > - printf("\n crackers.createPieceMap Unexpected case: Low node is NULL\n "); Printf is not to be used for this. Either you want to leave a debugging message, then use stream_printf(GDKout,"\n..... or return an exception string so the upper layers can deal with it > + return NULL; > if (nodeHgh == NULL) > - printf("\n crackers.createPieceMap Unexpected case: Hgh node is NULL \n "); > + return NULL; > > if (nodeLow->indexLocal == 0) pos1 = 0; > else pos1 = nodeLow->indexLocal + 1; > @@ -920,7 +920,7 @@ > return 0; > > if ((h = BATdescriptor(cur->tape)) == NULL) > - printf("\n\n crackers.sync Cannot access tape \n\n"); > + return -1; > > /* check if the current pair is already synced */ > cursor = getTapeCursor(cur,tailBatId); > @@ -936,7 +936,7 @@ > } > /* Take the index of the bat */ > if ((c = BATdescriptor(CrackerIndex[m].cid)) == NULL) > - printf(" \n\n crackers.sync Cannot access crack index \n\n"); > + return -1; > > syncs = size - cursor; > > @@ -1057,7 +1057,8 @@ > > @= EnrichMaxTailResultIncrementalSideways > size+=@5; > - > + if (pairt==NULL) > + throw(MAL,"pcrack", "Unexpected error during max. Empty input."); > if (BATcount(p) == 0){ > *maxt = *pairt; > j = 1; > @@ -1070,6 +1071,8 @@ > *maxt = *pairt; > pairt ++; > } > + if(piece==NULL) > + throw(MAL,"pcrack", "Unexpected error. Cur piece is NULL."); > if (newPiece) > BBPkeepref(piece->batCacheid); > else > @@ -1106,6 +1109,8 @@ > if (*inclusiveLow2==FALSE && *inclusiveHgh2==FALSE){ > @:analyzeTailConjunction(@2,@3,@4,GT,LT,@5)@ > } > + if(piece==NULL) > + throw(MAL,"pcrack", "Unexpected error. Cur piece is NULL."); > if (newPiece) > BBPkeepref(piece->batCacheid); > else > @@ -1143,6 +1148,8 @@ > @:analyzeTailConjunctionPivot(@2,@3,@4,GT,LT,@5)@ > } > > + if(piece==NULL) > + throw(MAL,"pcrack", "Unexpected error. Cur piece is NULL."); > if (newPiece) > BBPkeepref(piece->batCacheid); > else > @@ -1159,6 +1166,8 @@ > pivott ++; > > } > + if(piece==NULL) > + throw(MAL,"pcrack", "Unexpected error in projection. Cur piece is NULL."); > if (newPiece) > BBPkeepref(piece->batCacheid); > else > @@ -1177,6 +1186,8 @@ > pivott ++; > > } > + if(piece==NULL) > + throw(MAL,"pcrack", "Unexpected error. Cur piece is NULL."); > if (newPiece) > BBPkeepref(piece->batCacheid); > else > @@ -1271,11 +1282,19 @@ > @ > > @= SyncAndCrackBasedonFirstBound > - SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, FALSE); > + syncs=SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, FALSE); > + if (syncs<0) > + throw(MAL,"pcrack", "Failed to access cracker index or tape during syncing."); > + > foundLow = GetLowNodes_@1(*low, *inclusiveLow, CrackerIndex[h].Tree, cm, BUNfirst(cm), &localNodeLow1, &localNodeHgh1, NULL, NULL); > - if (foundLow == 0) > - if ((SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, TRUE))>0) > + > + if (foundLow == 0){ > + syncs=SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, TRUE); > + if (syncs<0) > + throw(MAL,"pcrack", "Failed to access cracker index or tape during syncing."); > + if (syncs>0) > foundLow = GetLowNodes_@1(*low, *inclusiveLow, CrackerIndex[h].Tree, cm, BUNfirst(cm), &localNodeLow1, &localNodeHgh1, NULL, NULL); > + } > foundHgh = 1; > base = nodeLow1->indexLocal; > CrackPiece = SyncAndCrackBasedonFirstBound = TRUE; > @@ -1288,7 +1307,9 @@ > @ > > @= SyncAndCrackBasedonLastBound > - SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, FALSE); > + syncs=SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, FALSE); > + if (syncs<0) > + throw(MAL,"pcrack", "Failed to access cracker index or tape during syncing."); > > /* if the high bound falls in here we crack this piece */ > if ( (*(@1*)Tloc(c, BUNfirst(c)+nodeHgh1->position)) > *hgh || > @@ -1296,9 +1317,13 @@ > nodeHgh1->inclusive == HBound) ){ > foundHgh = GetHghNodes_@1(*hgh, *inclusiveHgh, CrackerIndex[h].Tree, cm, BUNfirst(cm), &localNodeLow2, &localNodeHgh2, NULL, NULL); > > - if (foundHgh == 0) > - if ((SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, TRUE)) > 0) > + if (foundHgh == 0){ > + syncs = SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, TRUE); > + if (syncs<0) > + throw(MAL,"pcrack", "Failed to access cracker index or tape during syncing."); > + if (syncs > 0) > foundHgh = GetHghNodes_@1(*hgh, *inclusiveHgh, CrackerIndex[h].Tree, cm, BUNfirst(cm), &localNodeLow2, &localNodeHgh2, NULL, NULL); > + } > > foundLow = 1; > base = nodeLow1->indexLocal; > @@ -1317,13 +1342,19 @@ > @ > > @= SyncAndCrackBasedonBothBounds > - SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, FALSE); > + syncs=SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, FALSE); > + if (syncs<0) > + throw(MAL,"pcrack", "Failed to access cracker index or tape during syncing."); > + > /* get the new node after the sync */ > foundLow = GetLowNodes_@1(*low, *inclusiveLow, CrackerIndex[h].Tree, cm, BUNfirst(cm), &localNodeLow1, &localNodeHgh1, NULL, NULL); > foundHgh = GetHghNodes_@1(*hgh, *inclusiveHgh, CrackerIndex[h].Tree, cm, BUNfirst(cm), &localNodeLow2, &localNodeHgh2, NULL, NULL); > > if (foundLow == 0 || foundHgh == 0){ > - if ((SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, TRUE)) > 0 ){ > + syncs=SyncPiece_@1_@2(h, piece, nodeLow1, m, *pbid, TRUE); > + if (syncs<0) > + throw(MAL,"pcrack", "Failed to access cracker index or tape during syncing."); > + if (syncs > 0 ){ > foundLow = GetLowNodes_@1(*low, *inclusiveLow, CrackerIndex[h].Tree, cm, BUNfirst(cm), &localNodeLow1, &localNodeHgh1, NULL, NULL); > foundHgh = GetHghNodes_@1(*hgh, *inclusiveHgh, CrackerIndex[h].Tree, cm, BUNfirst(cm), &localNodeLow2, &localNodeHgh2, NULL, NULL); > } > @@ -1341,6 +1372,8 @@ > @= makeNewMapPiece1 > /*printStorageInfo(); can be used to what is in the Storage management structure */ > piece = createPieceMap_@1_@2(b, tailBAT, nodeLow1, nodeHgh1, m); > + if (piece==NULL) > + throw(MAL,"pcracking","Failed to create map piece"); > newPiece = TRUE; > > localFirst = addCrackerIndexIncrementalSideways_@1(h, *(@1*)Tloc(c, BUNfirst(c)+nodeLow1->position), nodeLow1->inclusive, 0, nodeLow1->indexLocal, cm, FALSE, TRUE, piece->batCacheid); > @@ -1350,6 +1383,8 @@ > > @= makeNewMapPiece2 > piece = createPieceMap_@1_@2(b, tailBAT, nodeLow1, nodeHgh1, m); > + if (piece==NULL) > + throw(MAL,"pcracking","Failed to create map piece"); > newPiece = TRUE; > localNodeLow1->first = TRUE; > localNodeLow1->indexLocal = 0; > @@ -1421,12 +1456,16 @@ > crkTwoLTree = TRUE; > else{ > posl = 0; > + if (nodeHgh1==NULL) > + throw(MAL,"pcrack", "Unexpected error. High node is NULL."); > posh = nodeHgh1->indexLocal; > crkThreeTree = TRUE; > } > done = TRUE; > }else > if (nodeHgh1 == NULL && nodeHgh2 == NULL) { > + if (nodeLow1==NULL) > + throw(MAL,"pcrack", "Unexpected error. Low node is NULL."); > if (foundLow != 0){ > nodeLow1->first = TRUE; > crkTwoRTree = TRUE; > @@ -1442,6 +1481,8 @@ > else > /* A previous query has already created a piece for this area */ > if (nodeLow1->first == TRUE){ > + if (nodeHgh1==NULL) > + throw(MAL,"pcrack", "Unexpected error. High node is NULL."); > > @:makeNewMapPiece1(@1,@2)@ > > @@ -1463,6 +1504,8 @@ > nodeLow1->first = TRUE; > else > if (foundLow == 0 && foundHgh ==0){ > + if (nodeHgh1==NULL) > + throw(MAL,"pcrack", "Unexpected error. High node is NULL."); > posl = nodeLow1->indexLocal+1; > posh = nodeHgh1->indexLocal; > crkThreeTree = TRUE; > @@ -1533,6 +1576,7 @@ > bit AnalyzeRemainingPiece = FALSE; > bit crkTwoLTree, crkTwoRTree, crkThreeTree; > bit CrackPiece = FALSE, SyncAndCrackBasedonFirstBound = FALSE, SyncAndCrackBasedonBothBounds = FALSE, SyncAndCrackBasedonLastBound = FALSE; > + lng syncs=0; > > if (@3_GT(low,hgh,@4@1)) > throw(MAL, "crackers.crack", "illegal range"); > @@ -1662,6 +1706,8 @@ > curPieceNodeLast = getNextNonLocalNode(localNodeHgh1); > } else > if (localNodeLow1->localBound == FALSE && localNodeLow1->first == FALSE){ > + if (localNodeLow2==NULL) > + throw(MAL,"pcrack", "Unexpected error. Low node is NULL."); > if (*(oid*)Hloc(cm,BUNfirst(cm)+localNodeLow1->position) == *(oid*)Hloc(cm,BUNfirst(cm)+localNodeLow2->position)) > /* Both bounds fall within a non materialized area of the map */ > BothBoundsWithinAnExistingArea=TRUE; > @@ -1716,14 +1762,15 @@ > Each piece in this area needs to be synced if necessary and enrich the result > If the hgh bound falls in a piece then we also have to crack it */ > while(done == FALSE){ > + if (curPieceNodeLast==NULL || curCBatNodeLast ==NULL) > + throw(MAL,"pcrack", "Unexpected error. Low node is NULL."); > + > LastBoundWithinAnExistingArea = FALSE; > localNodeLow1 = curPieceNodeLast; > localNodeHgh1 = getNextNonLocalNode(findNextPiece(localNodeLow1)); > nodeLow1 = curCBatNodeLast; > nodeHgh1 = findNextPiece(nodeLow1); > > - if (localNodeLow1==NULL) > - throw(MAL, "partial sideways cracking", "Unexpected error while traversing cracker map. Low node is NULL."); > > if (localNodeHgh1==NULL){ > if (nodeHgh1 == NULL){ > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

1 0

Re: [Monetdb-developers] [Monetdb-sql-checkins] sql/src/test/BugTracker-2009/Tests All, Nov2009, 1.51.2.4, 1.51.2.5
by Stefan Manegold 09 Nov '09

09 Nov '09

On Mon, Nov 09, 2009 at 10:22:40PM +0000, Niels Nes wrote: > Update of /cvsroot/monetdb/sql/src/test/BugTracker-2009/Tests > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv16258 > > Modified Files: > Tag: Nov2009 > All > Log Message: > disable a few more test (no propagation) I took care of preventing the propagation. Stefan > > Index: All > =================================================================== > RCS file: /cvsroot/monetdb/sql/src/test/BugTracker-2009/Tests/All,v > retrieving revision 1.51.2.4 > retrieving revision 1.51.2.5 > diff -u -d -r1.51.2.4 -r1.51.2.5 > --- All 8 Nov 2009 20:11:51 -0000 1.51.2.4 > +++ All 9 Nov 2009 22:22:38 -0000 1.51.2.5 > @@ -58,9 +58,9 @@ > missing_column_name.SF-2776100 > dumping_tables.SF-2776908 > dumping_tables.SF-2776908--performance > -dumping_tables.SF-2776908--optimizers > +#dumping_tables.SF-2776908--optimizers > name_clash_with_dump.SF-2780395 > -temporary_table_leftover.SF-2779437 > +#temporary_table_leftover.SF-2779437 > temporary_table_leftover.SF-2734713 > multi-column_join_with_expression.SF-2783279 > BOM.SF-2787813 > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Monetdb-sql-checkins mailing list > Monetdb-sql-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins > -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |

1 0

Re: [Monetdb-developers] [Monetdb-sql-checkins] sql/src/test/BugDay_2005-10-06_2.9.3/Tests All, Nov2009, 1.15, 1.15.2.1
by Stefan Manegold 09 Nov '09

09 Nov '09

On Mon, Nov 09, 2009 at 10:13:36PM +0000, Niels Nes wrote: > Update of /cvsroot/monetdb/sql/src/test/BugDay_2005-10-06_2.9.3/Tests > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv15481/src/test/BugDay_2005-10-06_2.9.3/Tests > > Modified Files: > Tag: Nov2009 > All > Log Message: > disable test (should not be propagated) I took care of preventing the propagation. Stefan > > Index: All > =================================================================== > RCS file: /cvsroot/monetdb/sql/src/test/BugDay_2005-10-06_2.9.3/Tests/All,v > retrieving revision 1.15 > retrieving revision 1.15.2.1 > diff -u -d -r1.15 -r1.15.2.1 > --- All 14 Aug 2009 12:50:04 -0000 1.15 > +++ All 9 Nov 2009 22:13:34 -0000 1.15.2.1 > @@ -1,7 +1,7 @@ > jdbc_crashes_on_getTables.SF_944316 > variable_arg_substring.SF_942981 > UNION_JOIN_vs_plain_set_UNION-2.SF-920585 > -huge_expression_and_column_name.SF-921173 > +#huge_expression_and_column_name.SF-921173 > CrashMe_SQL_server_crash-2.SF-921673 > CrashMe_SQL_server_crash-1.SF-921673 > inserts_with_defaults.SF-921977 > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Monetdb-sql-checkins mailing list > Monetdb-sql-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins > > -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |

1 0

Re: [Monetdb-developers] [Monetdb-sql-checkins] sql/src/test/Tests All, Nov2009, 1.61, 1.61.6.1
by Stefan Manegold 09 Nov '09

09 Nov '09

On Mon, Nov 09, 2009 at 10:12:30PM +0000, Niels Nes wrote: > Update of /cvsroot/monetdb/sql/src/test/Tests > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv15428/src/test/Tests > > Modified Files: > Tag: Nov2009 > All > Log Message: > Disabled crashme test (should not be propagated) I took care of preventing the propagation. Stefan > > Index: All > =================================================================== > RCS file: /cvsroot/monetdb/sql/src/test/Tests/All,v > retrieving revision 1.61 > retrieving revision 1.61.6.1 > diff -u -d -r1.61 -r1.61.6.1 > --- All 9 Apr 2009 18:48:49 -0000 1.61 > +++ All 9 Nov 2009 22:12:28 -0000 1.61.6.1 > @@ -87,7 +87,7 @@ > setoptimizer > load_dec_as_int > string > -NOT_WIN32?crashme > +#NOT_WIN32?crashme > 50ways > load_with_offset > copy_into > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Monetdb-sql-checkins mailing list > Monetdb-sql-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins > > -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |

1 0

Re: [Monetdb-developers] [Monetdb-checkins] clients/src/mapiclient dump.c, Nov2009, 1.50.2.2, 1.50.2.3
by Stefan Manegold 06 Nov '09

06 Nov '09

On Fri, Nov 06, 2009 at 09:10:01PM +0000, Sjoerd Mullender wrote: > Update of /cvsroot/monetdb/clients/src/mapiclient > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv11170 > > Modified Files: > Tag: Nov2009 > dump.c > Log Message: > cap needs to be an int. Solving the problem by adding a cast. Thanks for watching & fixing! ... and sorry for not paying sufficient attention myself (relied to much on the compilers, none complained, neither on Windows nor on Linux ...) Stefan > > Index: dump.c > =================================================================== > RCS file: /cvsroot/monetdb/clients/src/mapiclient/dump.c,v > retrieving revision 1.50.2.2 > retrieving revision 1.50.2.3 > diff -u -d -r1.50.2.2 -r1.50.2.3 > --- dump.c 6 Nov 2009 19:58:34 -0000 1.50.2.2 > +++ dump.c 6 Nov 2009 21:09:56 -0000 1.50.2.3 > @@ -293,8 +293,8 @@ > char *view = NULL; > size_t maxquerylen; > char *sname = NULL; > - ssize_t cap; > -#define CAP(X) ((cap = (X)) < 0 ? 0 : cap) > + int cap; > +#define CAP(X) ((cap = (int) (X)) < 0 ? 0 : cap) > > > if (schema == NULL) { > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins > > -- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |

1 0

Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal mal_io.mx, Nov2009, 1.48.6.2, 1.48.6.3 mal_mapi.mx, Nov2009, 1.37.2.6, 1.37.2.7 recycle.mx, Nov2009, 1.66.2.1, 1.66.2.2
by Sjoerd Mullender 06 Nov '09

06 Nov '09

Martin Kersten wrote: > Update of /cvsroot/monetdb/MonetDB5/src/modules/mal > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv8920 > > Modified Files: > Tag: Nov2009 > mal_io.mx mal_mapi.mx recycle.mx > Log Message: > A few Coverity changes. > > > Index: mal_mapi.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/mal_mapi.mx,v > retrieving revision 1.37.2.6 > retrieving revision 1.37.2.7 > diff -u -d -r1.37.2.6 -r1.37.2.7 > --- mal_mapi.mx 3 Nov 2009 20:15:01 -0000 1.37.2.6 > +++ mal_mapi.mx 6 Nov 2009 15:17:13 -0000 1.37.2.7 > @@ -402,8 +402,8 @@ > char *buf = (char *) GDKmalloc(BLOCK + 1); > char *challenge; > char *algos; > - stream *fdin = block_stream(in); > - stream *fdout = block_stream(out); > + stream *fdin; > + stream *fdout; > bstream *bs; > int len = 0; > > @@ -411,10 +411,12 @@ > GDKsyserror("SERVERlisten:"MAL_MALLOC_FAIL); > return; > } > + fdin = block_stream(in); > if (!fdin || !fdout) { > GDKsyserror("SERVERlisten:fdin or fdout problems"); > return; > } > + fdout = block_stream(out); > > assert(buf); > > You're assigning to fdout *after* checking whether it is NULL. -- Sjoerd Mullender

1 0