Hello developers,
Taking the opportunity from this commit, I wanted to initiate a
discussion with respect the executable names inside the code. A few
weeks ago I faced a problem when using the configure options
--program-prefix and --program-suffix, that change the executable names.
The problem was that the name mserver5 was hard coded and the daemon
could not find the actual executable.
I see two possible solutions:
1. Implement a mechanism that make a note in the monetdb_config.h
2. Implement a run time mechanism to compute the relevant file names.
Solution #1 is probably a bit more difficult because the prefix/suffix
transformation of the file names happens during the installation.
Solution #2 is already partially implemented in the daemon (see the
function get_bin_path in the file mutils.c), but will probably need to
be generalized somehow.
Comments? Ideas?
Best,
Panos.
Mark Raasveldt @ 2017-06-15 13:22 GMT:
> Changeset: 44e0bc7dab59 for MonetDB
> URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=44e0bc7dab59
> Modified Files:
> sql/backends/monet5/UDF/pyapi/pyapi.c
> Branch: Jul2017
> Log Message:
>
> Initialize sys.argv, because tensorflow requires this.
>
>
> diffs (20 lines):
>
> diff --git a/sql/backends/monet5/UDF/pyapi/pyapi.c b/sql/backends/monet5/UDF/pyapi/pyapi.c
> --- a/sql/backends/monet5/UDF/pyapi/pyapi.c
> +++ b/sql/backends/monet5/UDF/pyapi/pyapi.c
> @@ -1425,9 +1425,16 @@ PYFUNCNAME(PyAPIprelude)(void *ret) {
> MT_lock_init(&queryLock, "query_lock");
> MT_lock_set(&pyapiLock);
> if (!pyapiInitialized) {
> +#ifdef IS_PY3K
> + wchar_t* program = Py_DecodeLocale("mserver5", NULL);
> + wchar_t* argv[] = { program };
> +#else
> + char* argv[] = {"mserver5"};
> +#endif
> str msg = MAL_SUCCEED;
> PyObject *tmp;
> Py_Initialize();
> + PySys_SetArgvEx(1, argv, 0);
> _import_array();
> msg = _connection_init();
> if (msg != MAL_SUCCEED) {
> _______________________________________________
> checkin-list mailing list
> checkin-list(a)monetdb.org
> https://www.monetdb.org/mailman/listinfo/checkin-list
The MonetDB team at CWI/MonetDB BV is pleased to announce the
Dec2016-SP5 bugfix release of the MonetDB suite of programs.
More information about MonetDB can be found on our website at
<http://www.monetdb.org/>.
For details on this release, please see the release notes at
<http://www.monetdb.org/Downloads/ReleaseNotes>.
As usual, the download location is <http://dev.monetdb.org/downloads/>.
Dec 2016-SP5 bugfix release
Bug Fixes
* 6290: Crash (and assertion failure) with a correlated subquery with
NOT IN in the select-list
* 6291: crash if executes a function with sample operator
* 6294: Sqlitelogictest crash
* 6296: Another sqllitelogictest crash :(
* 6297: 7th sqllitelogictest crash :(
* 6300: Protect against missing BATs (sqlsmith)
* 6314: Lateral crash report (sqlsmith)
* 6315: Exist operator on type bigint missing (sqlsmith)
* 6316: Coalesc and limit error (sqlsmith)
* 6317: Two-column integer aggregation extremely slow
* 6318: Daemon crashes if .merovignian_properties for a database
contains more than 42 entries
* 6320: The daemon ignores all but the last entry in the
.merovignian_properties file when spawning mserver5
Thanks! This was one of the longest awaited fixes. Funny that it was just
about a newline.
Perhaps the bugfix can go to Dec2016?
Best, Roberto
On 31 May 2017 at 13:55, Panagiotis Koutsourakis <
commits+kutsurak=monetdbsolutions.com(a)monetdb.org> wrote:
> Changeset: e00fb765660d for MonetDB
> URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=e00fb765660d
> Modified Files:
> tools/merovingian/daemon/controlrunner.c
> Branch: Jul2017
> Log Message:
>
> Daemon was sending wrong answer for authorization request
>
> When the password was correct, the server would send one extra new line
> that
> confused the client. This commit fixes bug 3545
>
>
> diffs (12 lines):
>
> diff --git a/tools/merovingian/daemon/controlrunner.c
> b/tools/merovingian/daemon/controlrunner.c
> --- a/tools/merovingian/daemon/controlrunner.c
> +++ b/tools/merovingian/daemon/controlrunner.c
> @@ -169,7 +169,7 @@ control_authorise(
> }
> free(pwd);
>
> - mnstr_printf(fout, "=OK\n");
> + mnstr_printf(fout, "=OK");
> mnstr_flush(fout);
>
> return 1;
> _______________________________________________
> checkin-list mailing list
> checkin-list(a)monetdb.org
> https://www.monetdb.org/mailman/listinfo/checkin-list
>