On 31-10-2009 09:06:11 +0000, Martin Kersten wrote:
[snip]
> obj->name= GDKstrdup(name);
what if the GDKstrdup fails here?
> obj->sym= newMalBlk(MAXVARS,STMT_INCREMENT);
> obj->val = newGlobalStack(MAXVARS);
> + if ( obj->val == NULL)
> + showException(MAL,"box.new", MAL_MALLOC_FAIL);
I've been looking at mal_sabaoth to deal with GDKmalloc failures, and
there is a question to me in cases like this.
malloc failed, now the only right way to communicate that to the caller
is to throw an exception. However, doing that requires memory too (it
GDKmallocs too), so that will most probably fail too. Hence, the throw
will die, crash, or even worse, return NULL, which happens to mean
MAL_SUCCEED.
What should we do here? define a MAL_MALLOC_FAIL constant that we can
always return and that's recognised (and hence never freed), or do we
redefine MAL_SUCCEED to be non-NULL such that a real NULL means real
trouble, and thus an out of memory condition?
On Mon, Oct 26, 2009 at 04:49:49PM +0000, Henning Rode wrote:
> Update of /cvsroot/monetdb/pathfinder/modules/pftijah/tjc
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv28326
>
> Modified Files:
> tjc_milprint.c
> Log Message:
> try to fix compilation problem
In case you refer to this compilation problem
http://monetdb.cwi.nl/testing/projects/monetdb/Candidate/pathfinder/.GNU.64…http://www.ins.cwi.nl/~monet/permastore/2009-10-26/Candidate/make-pathfinde…
please note that this problem occurs with Candidate testing, i.e., (also) in
the Nov2009 release candidate branch, not (only) in the development trunk,
where your checkin went ...
Stefan
>
> Index: tjc_milprint.c
> ===================================================================
> RCS file: /cvsroot/monetdb/pathfinder/modules/pftijah/tjc/tjc_milprint.c,v
> retrieving revision 1.21
> retrieving revision 1.22
> diff -u -d -r1.21 -r1.22
> --- tjc_milprint.c 25 Sep 2009 07:22:33 -0000 1.21
> +++ tjc_milprint.c 26 Oct 2009 16:49:47 -0000 1.22
> @@ -306,11 +306,11 @@
> // for old index management
> if (tjc_c->maxfrag < 0) {
> TJCPRINTF(MILOUT,"ftindex := ftiName;\n");
> - TJCPRINTF(MILOUT,&tjc_c->milfragBUFF[0]);
> + TJCPRINTF(MILOUT,"%s", &tjc_c->milfragBUFF[0]);
> }
> for (c = 0; c <= tjc_c->maxfrag; c++) {
> TJCPRINTF(MILOUT,"ftindex := ftiName + \"%d\";\n", c);
> - TJCPRINTF(MILOUT,&tjc_c->milfragBUFF[0]);
> + TJCPRINTF(MILOUT,"%s", &tjc_c->milfragBUFF[0]);
> milprint_end_frag (tjc_c, tree, c);
> }
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> Monetdb-pf-checkins mailing list
> Monetdb-pf-checkins(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
>
--
| Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl |
| CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ |
| 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 |
| The Netherlands | Fax : +31 (20) 592-4312 |
In monetdb web-page I read the VOC tutorial and I see the the following:
shell> mclient -lsql -uvoc -Pvoc
sql> \< voc_dump.sql
Then I went to:
http://monetdb.cwi.nl/projects/monetdb/SQL/Documentation/MAPI-Client.html#M…
And for client options I see:
-P passwd | --passwd=passwd password
I just tried in my cvs head version and the option -P does not work. Reading some check ins in clients module, it seems
we have to use .monetdb file to avoid typing the password. However, the syntax of the file was not specified. I create
the file .monetdb with following content:
monetdb
monetdb
And I get the following message:
[goncalve@sirius scripts]$ ./mclient current debug sql
.monetdb:1: syntax error: monetdb
.monetdb:2: syntax error: monetdb
password:
I think we need some extra information about this new feature ;)
Regards,
Romulo
Fabian wrote:
> Update of /cvsroot/monetdb/clients/src/mapiclient
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv31397
>
> Modified Files:
> Tag: Aug2009
> dump.c
> Log Message:
> Stefan dK ran into a 'table is not unique' message, which IMO can only indicate something is seriously fubared
>
>
Would you please write in English?
http://www.merriam-webster.com/dictionary/ showed empty result on 'fubared'
and International Maritime Organization for the shortening IMO,
Thanks, Milena
> Index: dump.c
> ===================================================================
> RCS file: /cvsroot/monetdb/clients/src/mapiclient/dump.c,v
> retrieving revision 1.45.2.1
> retrieving revision 1.45.2.2
> diff -u -d -r1.45.2.1 -r1.45.2.2
> --- dump.c 22 Sep 2009 08:26:36 -0000 1.45.2.1
> +++ dump.c 22 Oct 2009 08:37:26 -0000 1.45.2.2
> @@ -342,9 +342,10 @@
>
> if (cnt != 1) {
> if (cnt == 0)
> - fprintf(stderr, "Table %s.%s does not exist.\n", schema, tname);
> + fprintf(stderr, "table %s.%s does not exist\n", schema, tname);
> else
> - fprintf(stderr, "Table %s.%s not unique.\n", schema, tname);
> + fprintf(stderr, "table %s.%s is not unique, corrupt catalog?\n",
> + schema, tname);
> goto bailout;
> }
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> Monetdb-checkins mailing list
> Monetdb-checkins(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
>
Shouldn't this have gone to the Nov2009 branch?
Martin Kersten wrote:
> Update of /cvsroot/monetdb/MonetDB5/src/modules/mal
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv8289
>
> Modified Files:
> tablet_sql.mx
> Log Message:
> Handle the case that an integer column is fed a string value that
> appears to match the null string.
>
>
> U tablet_sql.mx
> Index: tablet_sql.mx
> ===================================================================
> RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/tablet_sql.mx,v
> retrieving revision 1.9
> retrieving revision 1.10
> diff -u -d -r1.9 -r1.10
> --- tablet_sql.mx 2 Oct 2009 14:31:39 -0000 1.9
> +++ tablet_sql.mx 6 Oct 2009 13:33:45 -0000 1.10
> @@ -88,12 +88,21 @@
> #endif
> adt = fmt->nildata;
> fmt->c[0]->T->nonil = 0;
> - } else if ( quote && *s == quote ) {
> - s++; /* find the last quote */
> + } else
> + if ( quote && *s == quote ) {
> + /* strip the quotes when present */
> + s++;
> for ( t = e = s; *t ; t++)
> if ( *t == quote) e = t;
> *e = 0;
> adt = fmt->frstr(fmt, fmt->adt, s, e, 0);
> + /* The user might have specified a null string escape
> + e.g. NULL as '', which should be tested */
> + if (adt == NULL && s == e && fmt->nullstr &&
> + strncasecmp(s, fmt->nullstr, fmt->null_length+1) == 0){
> + adt = fmt->nildata;
> + fmt->c[0]->T->nonil = 0;
> + }
> } else {
> for( e=s; *e; e++)
> ;
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9-12, 2009. Register now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Monetdb-checkins mailing list
> Monetdb-checkins(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
--
Sjoerd Mullender
Shouldn't this have gone to the Nov2009 branch?
Martin Kersten wrote:
> Update of /cvsroot/monetdb/sql/src/backends/monet5
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv7452
>
> Modified Files:
> sql_result.mx
> Log Message:
> The loader now properly recognizes decimals read as integer values.
>
>
> U sql_result.mx
> Index: sql_result.mx
> ===================================================================
> RCS file: /cvsroot/monetdb/sql/src/backends/monet5/sql_result.mx,v
> retrieving revision 1.127
> retrieving revision 1.128
> diff -u -d -r1.127 -r1.128
> --- sql_result.mx 23 Sep 2009 07:36:21 -0000 1.127
> +++ sql_result.mx 6 Oct 2009 13:30:13 -0000 1.128
> @@ -381,8 +381,17 @@
> }
>
> len = (*BATatoms[type].atomFromStr)(s, &c->len, (ptr) &c->data);
> - if (len == 0 || len != e-s)
> + if (len == 0 || len != e-s){
> + /* decimals can be converted to integers when *.000 */
> + if ( s[len++] == '.')
> + switch( type ){
> + case TYPE_bte: case TYPE_int: case TYPE_lng: case TYPE_sht:
> + while (s[len]=='0') len++;
> + if ( s[len] == 0)
> + return c->data;
> + }
> return NULL;
> + }
> return c->data;
> }
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9-12, 2009. Register now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Monetdb-sql-checkins mailing list
> Monetdb-sql-checkins(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins
--
Sjoerd Mullender