On Fri, 31 Jul 2009, Niels Nes wrote:
Here you still asign something that could be NULL.
> dnode *n = selection->h;
>
> - (void) where;
> + if (!selection)
> + return sql_error(sql, 02, "SELECT: the selection or from part is missing");
So the asignment should be after the check.
Stefan
Fabian Groffen wrote:
> On 29-07-2009 20:19:48 +0000, Martin Kersten wrote:
>> octopus - check if the head is managed by merovingian
>
>> - if (list == NULL || needed == NULL){
>> + /* check if the head is properly administered for Octopus */
>> + SABAOTHgetLocalConnection(&name);
>
> This check will (almost) always succeed, setting name to non-NULL and
> by no means checks for merovingian. Is this what you intended to
> happen?
well, OPCinitcode uses this call and got a null pointer in the situation
that 1) 2 legs were created through monetdb and 2) the head was an
mserver5 started separately and not createdb with monetdb.
So, the test was for this null string and abandon octopus code.
Otherwise, the final derived code would contain a
remoter.connect(nil,"monetdb",....
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Monetdb-checkins mailing list
> Monetdb-checkins(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
Why do you want to be able to flush all changed files to disk? MonetDB
already does flushes when they are needed for transaction support. I
don't think we need to tell the kernel to synchronize any other files
with the disk. This function doesn't do anything with memory management
within the process.
Furthermore, this function is not available on Windows.
Martin Kersten wrote:
> Update of /cvsroot/monetdb/MonetDB5/src/modules/kernel
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv20459
>
> Modified Files:
> unix.mx
> Log Message:
> We want to experiment with complete flushing memory in out of memory
> queries.
>
>
> U unix.mx
> Index: unix.mx
> ===================================================================
> RCS file: /cvsroot/monetdb/MonetDB5/src/modules/kernel/unix.mx,v
> retrieving revision 1.24
> retrieving revision 1.25
> diff -u -d -r1.24 -r1.25
> --- unix.mx 7 Jan 2009 14:15:12 -0000 1.24
> +++ unix.mx 27 Jul 2009 06:29:44 -0000 1.25
> @@ -35,6 +35,10 @@
> address UNIXsetenv
> comment "Set the environment variable string.";
>
> +command sync() :void
> +address UNIXsync
> +comment "Flush memory, expensive but sometimes needed";
> +
> @- Implementation
> The remainder is a straight forward mapping to the underlying
> facilities
> @@ -113,4 +117,10 @@
> return MAL_SUCCEED;
> }
>
> +unix_export str UNIXsync(int *res);
> +str UNIXsync(int *res){
> + (void) res;
> + sync();
> + return MAL_SUCCEED;
> +}
> @}
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Monetdb-checkins mailing list
> Monetdb-checkins(a)lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
--
Sjoerd Mullender
Hi all,
I have lately re-installed the Jun2008 release of MonetDB/XQuery. I can
start Mserver successfully and connect to it with mclient to execute
XQueries.
When I try to connect to it using a MapiSocket from my java program, I
get the following error: "java.net.ConnectException: Connection refused".
I also tried:
> telnet localhost 50000
and I get:
Trying ::1...
telnet: connect to address ::1: Connection refused
Any idea what I could be doing wrong?
Thanks for your time,
Riham
The bug (#2787825) seems to be closed for comments, but I think this
bug should not be closed until the documentation gets updated.
typing "man mclient" on the stable branch tells me:
--statement=stmt (-s stmt)
Execute the specified query. The query is run before any queries
from files specified on the command line are run, and before the
interactive session is started (if the --interactive option is given).
This is not in line with Martin's latest comment. Martin, could you
re-open the bug (I don't have the permissions to do so)?
Greetings,
Wouter
2009/7/20 SourceForge.net <noreply(a)sourceforge.net>:
> Bugs item #2787825, was opened at 2009-05-06 14:21
> Message generated for change (Comment added) made by mlkersten
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=482468&aid=2787825&group_…
>
> Please note that this message will contain a full copy of the comment thread,
> including the initial issue submission, for this request,
> not just the latest update.
> Category: Mapi
> Group: Clients CVS Head
>>Status: Closed
>>Resolution: Wont Fix
> Priority: 5
> Private: No
> Submitted By: Wouter Alink (vzzzbx)
> Assigned to: Nobody/Anonymous (nobody)
> Summary: mclient: stdin + statement
>
> Initial Comment:
> It seems that there is a problem with both providing data via stdin and via the -s feature in mclient. (see example below).
>
> A possible solution could perhaps be to forbid this use. Another solution would be to define a behaviour: either read the '-s' first or the stdin first. (perhaps this already is the case, but I couldn't find any documentation about it)
>
> $ cat data.dat
> 1
> 2
> 3
> 4
> 5
> $ N=4; head -n $N data.dat | mclient -lsql -p50151 -dtest -s "copy $N records into aap from STDIN;"
> MAPI = monetdb@localhost:50151
> QUERY = copy 4 records into aap from STDIN;
> ERROR = !SQLException:sql:value ';' while parsing ';' from line 0 field 0 not inserted, expecting type int
> !SQLException:importTable:failed to import table
>
>
> ----------------------------------------------------------------------
>
>>Comment By: Martin Kersten (mlkersten)
> Date: 2009-07-20 21:48
>
> Message:
> Standard input is ignored in combination with -s.
> Closing it as at best it can be considered a niche feature request.
>
> ----------------------------------------------------------------------
>
> Comment By: Wouter Alink (vzzzbx)
> Date: 2009-05-07 21:55
>
> Message:
> as discussed on the monetdb-users list, using either the -s _or_ the stdin
> works fine (except for other reported/unreported bugs), but the combination
> fails. (stefan's example works fine).
>
> I can very well imagine that using a combination should not be allowed
> (and should not even become a feature request), but I feel that the current
> message is not very helpful.
>
> And, actually (I hadn't thought of this option before), if I would have
> specified "-i" then the documentation (mclient --help) says it reads from
> stdin _after_ reading the command line args, but it generates the same
> error.
>
> After some more tests I discovered that:
> - when using the command line args + stdin + mentioning '-i', the
> semi-colon after "copy $N records into aap from STDIN;" should be left out,
> so the following does work:
>
> $ echo "1
> 2
> 3
> 4
> 5" | mclient -lsql -dtest -hskadi -p50151 -i -s "COPY 5 RECORDS INTO aap
> FROM STDIN"
>
> (notice the omission of ';' after the COPY statement)
>
> If I do exactly the same, but leave out the '-i', no error is displayed,
> but nothing gets inserted either.
>
> If I use only stdin only:
>
> $ echo "COPY 5 RECORDS INTO aap FROM STDIN;
> 1
> 2
> 3
> 4
> 5" | mclient -lsql -dtest -hskadi -p50151
>
> then this works (only if the ';' after the COPY statement is present).
>
> I don't know whether there are two different bugs mentioned in this
> explanation, but I think there definitely is something wrong.
>
> by the way: the create statement for aap is: "CREATE TABLE aap (x int);"
>
> ----------------------------------------------------------------------
>
> Comment By: Stefan Manegold (stmane)
> Date: 2009-05-07 19:30
>
> Message:
> What about:
>
> { N=4 ; echo "copy $N records into aap from STDIN;" ; head -n $N data.dat
> ; } | mclient -lsql -p50151 -dtest
>
> ?
>
>
> ----------------------------------------------------------------------
>
> Comment By: Sjoerd Mullender (sjoerd)
> Date: 2009-05-07 14:26
>
> Message:
> Where does it say that this is supported?
> If it doesn't say anywhere, this is a feature request, not a bug.
>
> ----------------------------------------------------------------------
>
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=482468&aid=2787825&group_…
>