On Wed, Aug 16, 2006 at 05:30:30PM -0400, Luis Zarrabeitia wrote:
Not the '.' copyfrom patch, as it changes a sql specific issue in MapiClient which is a more general tool (also for xquery and mil/mal). I made some more changes in the sql frontend and ascii_io library to solve the proces | MapiClient problem with out '.' (just end of file should do).
I imagined that . could cause some semantic trouble. I went ahead anyway because I wanted "myprocess |" (or a "cat myfile |") to be able to execute more than one copyfrom and . seemed a good choice (postgres). I shouldn't have touched the MapiClient, though. I like that you fixed it. Would be acceptable to introduce the . without touching the MapiClient? (changes could be confined to ascii_io.mx)
Adding the '.' handling in ascii_io sounds fine with me. As long as its only an extra bonus, ie ascii_io should end with reaching the number of records, end of file or hitting . (be sure to see if it doesn't give problems with single non quoted string columns.
Niels
Niels
Zarrabeitia.