On Fri, Dec 21, 2007 at 11:55:34AM +0100, Peter Boncz wrote:
Hi Sjoerd,
Thanks for fixing some things I was unaware of (empty lines in other languages?)
(As usually) Testing was aware and told us about it ;-)
In detail (as far as I can quickly recall): Many MIL and almost all(?) SQL test failed, as they list multiple statements in one script, each terminated by the mandatory ';' but also oftenseparated by empty lines for human readability. The latter is perfectly sound with the respective languages syntaxes. Testing (Mtest.py) runs (most) (server and client) tests by redirecting the given test script to the server's/client's standard input (as opposed to reading from a file --- a feature that was originally introduced to keep the tests going beyond the first error), and with yoru changes, mclient apparently considered an empty line to be the end of a session.
Stefan
The timer is again started when the first line of a query is typed. This is the case for *all* languages.
I cannot image cases where it is useful for mclient to keeps stays on someone's typing speed, while I can image cases where one would like to have information about query performance. Do others agree?
(I maybe unjustly assumed that timing query performance was the intended behavior)
Peter
-----Original Message----- From: monetdb-checkins-bounces@lists.sourceforge.net [mailto:monetdb-checkins-bounces@lists.sourceforge.net] On Behalf Of Sjoerd Mullender Sent: Wednesday, December 19, 2007 3:04 PM To: monetdb-checkins@lists.sourceforge.net Subject: [Monetdb-checkins] clients/src/mapiclient MapiClient.mx,Clients_1-20, 1.88.2.4, 1.88.2.5
Update of /cvsroot/monetdb/clients/src/mapiclient In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv6918
Modified Files: Tag: Clients_1-20 MapiClient.mx Log Message: Did Peter's checkin and Niels' fix correctly: In XQuery mode, when typing <> when there is no query yet will result in just asking for more data, and empty lines in other modes will not end the session. Also fixed \f processing in that the new value is now remembered for a subsequent bare \f. The timer is again started when the first line of a query is typed. This is the case for *all* languages.
[...]