Good point. Thanks!
I don't expect any problems with this change, mostly because we don't have any MacOS X machine for testing, anymore; only one for buildbot --- once that's running again,we'll see ... Assuming that compilation works for you on a "modern" MacOS X (Snow Leopard), I assume that the mentioned bison.simple problems were related/specific to an older version of MacOS X, only.
(MacOS X was never a primary develoment platform for us, that why disabling -Wuninitialized (by enabling -Wno-uninitialized) on MacOS X used to be - "acceptable" for us; obviously, with you using MacOS X as a primary development platform, -Wno-uninitialized should indeed not be used - (gloablly) ...)
Stefan
On Thu, May 20, 2010 at 06:20:02PM +0200, Jan Rittinger wrote:
Changeset: 892fc9b323aa for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=892fc9b323aa Modified Files: buildtools/conf/MonetDB.m4 Branch: default Log Message:
Remove the C flag -Wno-uninitialized for Mac operating systems. This helps to detect uninitialized variables on OS X.
(Please undo the fix in case it breaks anything.)
diffs (12 lines):
diff -r b181da69e3ba -r 892fc9b323aa buildtools/conf/MonetDB.m4 --- a/buildtools/conf/MonetDB.m4 Thu May 20 17:50:15 2010 +0200 +++ b/buildtools/conf/MonetDB.m4 Thu May 20 18:18:33 2010 +0200 @@ -811,7 +811,7 @@ dnl generates "X_CFLAGS =" in the generated Makefile. NO_X_CFLAGS='X_CFLAGS' ;;
- *-solaris*|*-darwin*|*-aix*)
- *-solaris*|*-aix*) dnl In some cases, there is a (possibly) uninitialized dnl variable in bison.simple ... |-( X_CFLAGS="$X_CFLAGS -Wno-uninitialized"
Checkin-list mailing list Checkin-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/checkin-list