MonetDB: default - Progress bar: Ignore comments in trace output

Ying Zhang Y.Zhang at cwi.nl
Tue Feb 24 11:42:43 CET 2015


Hai Hannes,

Compiling default branch complains about "‘profiler_querystart’ may be used uninitialized":

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/ufs/zhang/monet/default/clients/mapiclient -I../.. -I/ufs/zhang/monet/default/clients/mapiclient -I../mapilib -I/ufs/zhang/monet/default/clients/mapiclient/../mapilib -I../../common/options -I/ufs/zhang/monet/default/clients/mapiclient/../../common/options -I../../common/stream -I/ufs/zhang/monet/default/clients/mapiclient/../../common/stream -I../R/MonetDB.R/src -I/ufs/zhang/monet/default/clients/mapiclient/../R/MonetDB.R/src -DLIBMCUTIL -O3 -pipe -Werror -Wall -Wextra -W -Werror-implicit-function-declaration -Wpointer-arith -Wdeclaration-after-statement -Wundef -Wformat=2 -Wno-format-nonliteral -Winit-self -Winvalid-pch -Wmissing-declarations -Wmissing-format-attribute -Wmissing-prototypes -Wold-style-definition -Wpacked -Wunknown-pragmas -Wvariadic-macros -fstack-protector-all -Wstack-protector -Wpacked-bitfield-compat -Wsync-nand -Wjump-misses-init -Wmissing-include-dirs -Wlogical-op -Wunreachable-code -D_FORTIFY_SOURCE=2 -D_REENTRANT -c /ufs/zhang/monet/default/clients/mapiclient/prompt.c  -fPIC -DPIC -o .libs/libmcutil_la-prompt.o
In file included from /ufs/zhang/monet/default/clients/mapiclient/profiler-dummy.c:5:0:
/ufs/zhang/monet/default/clients/mapiclient/../R/MonetDB.R/src/profiler.c: In function ‘profiler_thread’:
/ufs/zhang/monet/default/clients/mapiclient/../R/MonetDB.R/src/profiler.c:219:59 error: ‘profiler_querystart’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
          if (profiler_msgs_expect > 0 && (profiler_tsms() - profiler_querystart) > 500) {
                                                           ^

This seems to only happen if I use the --enable-optimize --disable-debug configure options.

Can I just initialise profiler_querystart with 0?

Thanks!

Jennie



> On Feb 20, 2015, at 18:39, Hannes Muehleisen <commits at monetdb.org> wrote:
> 
> Changeset: cde6ad120a72 for MonetDB
> URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=cde6ad120a72
> Modified Files:
> 	clients/R/MonetDB.R/src/profiler.c
> Branch: default
> Log Message:
> 
> Progress bar: Ignore comments in trace output
> 
> 
> diffs (13 lines):
> 
> diff --git a/clients/R/MonetDB.R/src/profiler.c b/clients/R/MonetDB.R/src/profiler.c
> --- a/clients/R/MonetDB.R/src/profiler.c
> +++ b/clients/R/MonetDB.R/src/profiler.c
> @@ -177,6 +177,9 @@ static void* profiler_thread(void* param
> 		recvd = read(profiler_socket, buf, sizeof(buf));
> 		if (recvd > 0) {
> 			buf[recvd] = 0;
> +			if (buf[0]== '#') {
> +				continue;
> +			}
> 			mapi_line_split(buf, elems, TRACE_NCOLS);
> 			if (strncmp(elems[TRACE_COL_STATEFL], "done", 4) != 0) {
> 				continue;
> _______________________________________________
> checkin-list mailing list
> checkin-list at monetdb.org
> https://www.monetdb.org/mailman/listinfo/checkin-list



More information about the developers-list mailing list