[Monetdb-developers] MonetDB: gdk-calc - gdk_calc.c, mod_typeswitchloop(): initialize...

Stefan Manegold Stefan.Manegold at cwi.nl
Thu Feb 16 09:27:32 CET 2012


Standard gcc on Fedora 16; MonetDB configured with --disable-debug --enable-optimize --disable-assert 

--
| Stefan.Manegold @ CWI.nl | DB Architectures (INS1) |
| http://CWI.nl/~manegold/ | Science Park 123 (L321) |
| Tel.: +31 (0)20 592-4212 | 1098 XG Amsterdam  (NL) |


----- Reply message -----
From: "Sjoerd Mullender" <sjoerd at acm.org>
To: <monetdb-developers at lists.sourceforge.net>
Subject: [Monetdb-developers] MonetDB: gdk-calc - gdk_calc.c,	mod_typeswitchloop(): initialize...
Date: Thu, Feb 16, 2012 09:18




On 2012-02-15 20:12, Stefan Manegold wrote:
> Changeset: fc0d3fad41c2 for MonetDB
> URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=fc0d3fad41c2
> Modified Files:
> 	gdk/gdk_calc.c
> Branch: gdk-calc
> Log Message:
> 
> gdk_calc.c, mod_typeswitchloop(): initialize "nils" (hopefully correctly)

Which sucky compiler was this?  There is no code path where nils was not
initialized.  (This also means that the value you choose here doesn't
matter.)

> 
> diffs (12 lines):
> 
> diff --git a/gdk/gdk_calc.c b/gdk/gdk_calc.c
> --- a/gdk/gdk_calc.c
> +++ b/gdk/gdk_calc.c
> @@ -6157,7 +6157,7 @@ mod_typeswitchloop(const void *lft, int 
>  		   void *dst, int tp, BUN cnt,
>  		   int abort_on_error, const char *func)
>  {
> -	BUN nils;
> +	BUN nils = BUN_NONE;
>  
>  	switch (ATOMstorage(tp1)) {
>  	case TYPE_bte:
> _______________________________________________
> Checkin-list mailing list
> Checkin-list at monetdb.org
> http://mail.monetdb.org/mailman/listinfo/checkin-list


-- 
Sjoerd Mullender



More information about the developers-list mailing list