[Monetdb-developers] MonetDB: default - Add test to prevent warning

Stefan Manegold Stefan.Manegold at cwi.nl
Tue Jun 1 12:32:23 CEST 2010


Arjen,

is this a fix that should also be include in the upcoming Jun2010 release?

If so, it would need to be back-ported to the Jun2010 branch ...

Stefan

On Tue, Jun 01, 2010 at 11:40:20AM +0200, Arjen de Rijke wrote:
> Changeset: 74ee41649425 for MonetDB
> URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=74ee41649425
> Modified Files:
> 	clients/src/php/native/lib/php_mapi.inc
> Branch: default
> Log Message:
> 
> Add test to prevent warning
> 
> 
> diffs (15 lines):
> 
> diff -r 80afe14ca780 -r 74ee41649425 clients/src/php/native/lib/php_mapi.inc
> --- a/clients/src/php/native/lib/php_mapi.inc	Tue Jun 01 10:02:37 2010 +0200
> +++ b/clients/src/php/native/lib/php_mapi.inc	Tue Jun 01 11:37:25 2010 +0200
> @@ -768,8 +768,10 @@
>  		global $connection_pool;
>  
>  		$connections = array();
> -		foreach($connection_pool as $conn) {
> +		if ($connection_pool !== null) {
> +		    foreach($connection_pool as $conn) {
>  			$connections[] = $conn["id"];
> +		    }
>  		}
>  
>  		$id = hash("sha1", time());
> _______________________________________________
> Checkin-list mailing list
> Checkin-list at monetdb.org
> http://mail.monetdb.org/mailman/listinfo/checkin-list
> 

-- 
| Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4199       |




More information about the developers-list mailing list