[Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal/rdf rdf_shredder.mx, Feb2010, 1.13, 1.13.2.1

Lefteris lsidir at gmail.com
Mon Feb 22 17:06:46 CET 2010


the tokenizer has been removed from the Makefile.ag of the stable
branch, and this #include can be deleted all the way. I have said many
times that none of this code is ready for stable branches and yes they
should have never been propagate to the stable. We haven't announced
any MonetDB/RDF module official so it should not be used by any user.

For me the #if 0 is not a problem

On Mon, Feb 22, 2010 at 4:46 PM, Fabian Groffen <Fabian.Groffen at cwi.nl> wrote:
> On 22-02-2010 15:43:44 +0000, Lefteris Sidirourgos wrote:
>> Update of /cvsroot/monetdb/MonetDB5/src/modules/mal/rdf
>> In directory sfp-cvsdas-1.v30.ch3.sourceforge.com:/tmp/cvs-serv32552/src/modules/mal/rdf
>>
>> Modified Files:
>>       Tag: Feb2010
>>       rdf_shredder.mx
>> Log Message:
>> disable the tokenizer.mx from m5
>
> Dunno if this was/is discussed, but isn't it a much cleaner solution to
> just remove it from the code base in this branch, and keep it as is in
> the HEAD (e.g. request to prevent propagation?).  The 'if 0's and
> commented out code look a bit messy.
>
>
>> Index: rdf_shredder.mx
>> ===================================================================
>> RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/rdf/rdf_shredder.mx,v
>> retrieving revision 1.13
>> retrieving revision 1.13.2.1
>> diff -u -d -r1.13 -r1.13.2.1
>> --- rdf_shredder.mx   8 Jan 2010 12:08:58 -0000       1.13
>> +++ rdf_shredder.mx   22 Feb 2010 15:43:41 -0000      1.13.2.1
>> @@ -27,7 +27,9 @@
>>  #include "url.h"
>>  #include "rdf.h"
>>  #include "raptor.h"
>> +#if 0
>>  #include "../tokenizer.h"
>> +#endif
>
> ------------------------------------------------------------------------------
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Monetdb-checkins mailing list
> Monetdb-checkins at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
>




More information about the developers-list mailing list