[Monetdb-developers] [Monetdb-pf-checkins] pathfinder/runtimeshredder.mx, Feb2010, 1.162, 1.162.2.1

Jan Flokstra flokstra at cs.utwente.nl
Fri Feb 19 08:46:08 CET 2010


On Thursday 18 February 2010 21:00, Jan Rittinger wrote:
> Hi Sjoerd,
>
> as far as I can remember we only use the DTD to resolve entities and id
> references. So if no DTD is available an error is triggered, but the
> document is still imported.
>
> Just my two cents...
>

Hi Sjoerd and Jan,

This is correct. But when the shredder was built I also had a couple of 
examples with DTD's which could not be found but where the document loaded 
correct so we decided not to bailout and only print an error. Maybe this 
solution is better,

Regards, Jan. 

> Jan
>
> On Feb 18, 2010, at 10:50, Sjoerd Mullender wrote:
> > Update of /cvsroot/monetdb/pathfinder/runtime
> > In directory sfp-cvsdas-1.v30.ch3.sourceforge.com:/tmp/cvs-serv30011
> >
> > Modified Files:
> >      Tag: Feb2010
> > 	shredder.mx
> > Log Message:
> > If there is no DTD, I guess there is not much point continuing.
> > Found by Coverity.
> >
> >
> > Index: shredder.mx
> > ===================================================================
> > RCS file: /cvsroot/monetdb/pathfinder/runtime/shredder.mx,v
> > retrieving revision 1.162
> > retrieving revision 1.162.2.1
> > diff -u -d -r1.162 -r1.162.2.1
> > --- shredder.mx	7 Jan 2010 15:24:29 -0000	1.162
> > +++ shredder.mx	18 Feb 2010 09:50:12 -0000	1.162.2.1
> > @@ -1362,8 +1362,10 @@
> >                 ctx->myDoc = xmlNewDoc(ctx->version);
> >             }
> >
> > -            if (!dtd)
> > +            if (!dtd) {
> >                 GDKerror("shred_external_subset: problem with reading
> > external DTD (\"%s\")\n", SystemID); +                BAILOUT(shredCtx);
> > +            }
> >
> >             if (ctx->myDoc->extSubset) {
> >                 stream_printf(GDKout, "!WARNING: double external subset
> > (\"%s\") may cause problems.\n", SystemID);
> >
> >
> > -------------------------------------------------------------------------
> >----- Download Intel® Parallel Studio Eval
> > Try the new software tools for yourself. Speed compiling, find bugs
> > proactively, and fine-tune applications for parallel performance.
> > See why Intel Parallel Studio got high marks during beta.
> > http://p.sf.net/sfu/intel-sw-dev
> > _______________________________________________
> > Monetdb-pf-checkins mailing list
> > Monetdb-pf-checkins at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins




More information about the developers-list mailing list