[Monetdb-developers] [Monetdb-checkins] MonetDB5/src/mal mal_authorize.mx, , 1.73, 1.74 mal_client.mx, , 1.195, 1.196 mal_debugger.mx, , 1.263, 1.264 mal_exception.mx, , 1.54, 1.55 mal_factory.mx, , 1.87, 1.88 mal_interpreter.mx, , 1.302, 1.303 mal_linker.mx, , 1.110, 1.111 mal_profiler.mx, , 1.128, 1.129 mal_sabaoth.mx, , 1.53, 1.54 mal_scenario.mx, , 1.123, 1.124 mal_session.mx, , 1.195, 1.196

Martin Kersten Martin.Kersten at cwi.nl
Sat May 16 22:28:29 CEST 2009


Fabian Groffen wrote:
> On 16-05-2009 18:26:25 +0000, Martin Kersten wrote:
>> Update of /cvsroot/monetdb/MonetDB5/src/mal
>> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv27406
>>
>> Modified Files:
>> 	mal_authorize.mx mal_client.mx mal_debugger.mx 
>> 	mal_exception.mx mal_factory.mx mal_interpreter.mx 
>> 	mal_linker.mx mal_profiler.mx mal_sabaoth.mx mal_scenario.mx 
>> 	mal_session.mx 
>> Log Message:
>> Collecting the exception/errors messages in one place leads to easier detection
>> of duplicates and can be used later for internationalization efforts
> 
> Why not do it the gettext way, in that case?
Yes, i am fully aware of gettext.
It is a multi-step process, first condense.....
and gettext() performs translations based on strings
e.g. the ones now identified.
> 
>> U mal_linker.mx
>> Index: mal_linker.mx
>> ===================================================================
>> RCS file: /cvsroot/monetdb/MonetDB5/src/mal/mal_linker.mx,v
>> retrieving revision 1.110
>> retrieving revision 1.111
>> diff -u -d -r1.110 -r1.111
>> --- mal_linker.mx	7 Jan 2009 14:15:12 -0000	1.110
>> +++ mal_linker.mx	16 May 2009 18:26:23 -0000	1.111
>> @@ -251,7 +251,7 @@
>>  
>>  	if (fullname == NULL) {
>>  		if( flag)
>> -			throw(LOADER, "loadLibrary", "%s: file not found", filename);
>> +			throw(LOADER, "loadLibrary", RUNTIME_FILE_NOT_FOUND, filename);
> 
> I think this is prone to errors and mistakes, since you no longer know
> how many %X are in the constant, of what type, etc.
true... see how many are really needed after condensation

> 
> I do think consistency is good, I doubt about translations, but I think
> this approach is a good solution.  Please look into gettext, see
> applications like mutt for an example how to use it.
> 
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables 
> unlimited royalty-free distribution of the report engine 
> for externally facing server and web deployment. 
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Monetdb-checkins mailing list
> Monetdb-checkins at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins





More information about the developers-list mailing list