[Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal pcre.mx, , 1.77, 1.78

Stefan Manegold Stefan.Manegold at cwi.nl
Wed May 6 15:56:02 CEST 2009


... please ignore --- I replied before seeing your rollback ...

Stefan

On Wed, May 06, 2009 at 03:55:04PM +0200, Stefan Manegold wrote:
> Peter,
> 
> I do not like this change very much.
> 
> To ensure portability, we require that <PKG>_config.h (here: mal_config.h)
> is the very first include in each C file.
> 
> Moving '#include "mal_config.h"' behind '#include "mal_config.h"' might
> cause unintended/unexpected problems now or in the future on other systems
> than Red Hat 4.3.2-7.
> 
> Likewise, a hardwired and unconditional '#define _GNU_SOURCE 1' will not
> work on all systems.
> 
> If Red Hat 4.3.2-7 indeed needs some special treatment, we should better try
> to fix our configure script(s) accordingly than have these hardcode fixes in
> the code itself.
> 
> Stefan
> 
> On Wed, May 06, 2009 at 01:10:59PM +0000, Peter Boncz wrote:
> > Update of /cvsroot/monetdb/MonetDB5/src/modules/mal
> > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv1809
> > 
> > Modified Files:
> > 	pcre.mx 
> > Log Message:
> > make it compile on Red Hat 4.3.2-7 
> > 
> > 
> > 
> > U pcre.mx
> > Index: pcre.mx
> > ===================================================================
> > RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/pcre.mx,v
> > retrieving revision 1.77
> > retrieving revision 1.78
> > diff -u -d -r1.77 -r1.78
> > --- pcre.mx	4 May 2009 13:53:25 -0000	1.77
> > +++ pcre.mx	6 May 2009 13:10:53 -0000	1.78
> > @@ -123,9 +123,10 @@
> >  @+ Implementation
> >  @include prelude.mx
> >  @c
> > -#include "mal_config.h"
> > +#define _GNU_SOURCE 1
> >  #include <string.h>
> >  
> > +#include "mal_config.h"
> >  #include "mal.h"
> >  #include "mal_exception.h"
> >  
> > @@ -142,6 +143,7 @@
> >  
> >  #include <pcre.h>
> >  
> > +
> >  pcre_export str PCREquote(str *r, str *v);
> >  pcre_export str PCREselect(int *res, str *pattern, int *bid);
> >  pcre_export str PCREuselect(int *res, str *pattern, int *bid);
> > 
> > 
> > ------------------------------------------------------------------------------
> > The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
> > production scanning environment may not be a perfect world - but thanks to
> > Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
> > Series Scanner you'll get full speed at 300 dpi even with all image 
> > processing features enabled. http://p.sf.net/sfu/kodak-com
> > _______________________________________________
> > Monetdb-checkins mailing list
> > Monetdb-checkins at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
> > 
> 
> -- 
> | Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
> | CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
> | 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
> | The Netherlands     | Fax : +31 (20) 592-4312       |

-- 
| Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4312       |




More information about the developers-list mailing list