[Monetdb-developers] [Monetdb-checkins] MonetDB5/src/optimizer opt_octopus.mx, , 1.57, 1.58 opt_macro.mx, , 1.47, 1.48

Martin Kersten Martin.Kersten at cwi.nl
Wed Jul 29 22:35:49 CEST 2009


Fabian Groffen wrote:
> On 29-07-2009 20:19:48 +0000, Martin Kersten wrote:
>> octopus - check if the head is managed by merovingian
> 
>> -	if (list == NULL || needed == NULL){
>> +	/* check if the head is properly administered for Octopus */
>> +	SABAOTHgetLocalConnection(&name);
> 
> This check will (almost) always succeed, setting name to non-NULL and
> by no means checks for merovingian.  Is this what you intended to
> happen?
well, OPCinitcode uses this call and got a null pointer in the situation
that 1) 2 legs were created through monetdb and 2) the head was an
mserver5 started separately and not createdb with monetdb.

So, the test was for this null string and abandon octopus code.
Otherwise, the final derived code would contain a
remoter.connect(nil,"monetdb",....
> 
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with 
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Monetdb-checkins mailing list
> Monetdb-checkins at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins





More information about the developers-list mailing list