[Monetdb-developers] [Monetdb-sql-checkins] sql/src/common sql_types.mx, Feb2009, 1.121.2.2, 1.121.2.3

Sjoerd Mullender sjoerd at acm.org
Fri Feb 27 08:46:53 CET 2009


On 2009-02-27 08:26, Stefan Manegold wrote:
> On Thu, Feb 26, 2009 at 11:47:57PM +0000, Roberto Cornacchia wrote:
>> Update of /cvsroot/monetdb/sql/src/common
>> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv3519/common
>>
>> Modified Files:
>>       Tag: Feb2009
>> 	sql_types.mx 
>> Log Message:
>> reverting addition of prob() aggregation, as it would break db compatibility
> 
> Thanks!
> (In particular for properly doing it using CVS commands, only!)
> 
> I prevented propagation of this "undo" to the developlment trunk;
> the "do" had already been propagated yesterday; hence, the prod()
> aggregation is now avilable in the development trunk.

I would dearly like to see that db backward compatibility is also 
maintained between stable and devel.  In other words, there has to be a 
smooth way forward without having to resort to dump/restore.  So I'm 
also not terribly happy with the change as it is now in the devel branch.

> Stefan
> 
>>
>> U sql_types.mx
>> Index: sql_types.mx
>> ===================================================================
>> RCS file: /cvsroot/monetdb/sql/src/common/sql_types.mx,v
>> retrieving revision 1.121.2.2
>> retrieving revision 1.121.2.3
>> diff -u -d -r1.121.2.2 -r1.121.2.3
>> --- sql_types.mx	26 Feb 2009 16:56:29 -0000	1.121.2.2
>> +++ sql_types.mx	26 Feb 2009 23:47:55 -0000	1.121.2.3
>> @@ -1361,35 +1361,6 @@
>>  	t++; /* LNG */
>>  	sql_create_aggr("sum", "aggr", "sum", *(t), *(t));
>>  
>> -	/* prod for numerical and decimals */
>> -	sql_create_aggr("prod", "aggr", "product", BTE, SHT);
>> -	sql_create_aggr("prod", "aggr", "product", BTE, INT);
>> -	sql_create_aggr("prod", "aggr", "product", BTE, WRD);
>> -	sql_create_aggr("prod", "aggr", "product", BTE, LNG);
>> -
>> -	sql_create_aggr("prod", "aggr", "product", SHT, INT);
>> -	sql_create_aggr("prod", "aggr", "product", SHT, WRD);
>> -	sql_create_aggr("prod", "aggr", "product", SHT, LNG);
>> -
>> -	sql_create_aggr("prod", "aggr", "product", INT, WRD);
>> -	sql_create_aggr("prod", "aggr", "product", INT, LNG);
>> -
>> -	sql_create_aggr("prod", "aggr", "product", WRD, WRD);
>> -	sql_create_aggr("prod", "aggr", "product", WRD, LNG);
>> -	sql_create_aggr("prod", "aggr", "product", LNG, LNG);
>> -
>> -	t = decimals; /* BTE */
>> -	sql_create_aggr("prod", "aggr", "product", *(t), *(t+1));
>> -	sql_create_aggr("prod", "aggr", "product", *(t), *(t+2));
>> -	sql_create_aggr("prod", "aggr", "product", *(t), *(t+3));
>> -	t++; /* SHT */
>> -	sql_create_aggr("prod", "aggr", "product", *(t), *(t+1));
>> -	sql_create_aggr("prod", "aggr", "product", *(t), *(t+2));
>> -	t++; /* INT */
>> -	sql_create_aggr("prod", "aggr", "product", *(t), *(t+1));
>> -	t++; /* LNG */
>> -	sql_create_aggr("prod", "aggr", "product", *(t), *(t));
>> -
>>  	for (t = numerical; t < floats; t++) {
>>  		sql_create_aggr("avg", "aggr", "avg", *(t), DBL);
>>  		sql_create_func("mod", "calc", "%", *t, *t, *t, SCALE_FIX);
>> @@ -1397,7 +1368,6 @@
>>  
>>  	for (t = floats; t < dates; t++) {
>>  		sql_create_aggr("sum", "aggr", "sum", *t, *t);
>> -		sql_create_aggr("prod", "aggr", "product", *t, *t);
>>  		sql_create_aggr("avg", "aggr", "avg", *t, DBL);
>>  
>>  		sql_create_func("mod", "calc", "fmod", *t, *t, *t, SCALE_FIX);
>>
>>
>> ------------------------------------------------------------------------------
>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
>> -Strategies to boost innovation and cut costs with open source participation
>> -Receive a $600 discount off the registration fee with the source code: SFAD
>> http://p.sf.net/sfu/XcvMzF8H
>> _______________________________________________
>> Monetdb-sql-checkins mailing list
>> Monetdb-sql-checkins at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins
> 


-- 
Sjoerd Mullender




More information about the developers-list mailing list