[Monetdb-developers] [Monetdb-sql-checkins] sql/src/storage store.mx, Feb2009, 1.25.2.1, 1.25.2.2

Sjoerd Mullender sjoerd at acm.org
Wed Apr 22 10:35:58 CEST 2009


On 2009-04-22 10:28, Niels Nes wrote:
> Update of /cvsroot/monetdb/sql/src/storage
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv10533/src/storage
> 
> Modified Files:
>       Tag: Feb2009
> 	store.mx 
> Log Message:
> fixing bad concurrency bug

Bad enough to rebuild the release candidates?

> 1) we lost updates
> 	Problem was in the handling of the update bat, ie we need to always
> 	keep updates in the update bat. But already apply asap.
> 
> 2) we got extra inserts (the hard problem)
> 	We incorrectly kept using an 'empty' bat. These are bats which should
> 	stay empty and are shared. But we incorrectly inserted data in it
> 	instead of replacing it with a new bat with data.
> 
> 
> U store.mx
> Index: store.mx
> ===================================================================
> RCS file: /cvsroot/monetdb/sql/src/storage/store.mx,v
> retrieving revision 1.25.2.1
> retrieving revision 1.25.2.2
> diff -u -d -r1.25.2.1 -r1.25.2.2
> --- store.mx	27 Feb 2009 22:23:00 -0000	1.25.2.1
> +++ store.mx	22 Apr 2009 08:28:22 -0000	1.25.2.2
> @@ -1850,8 +1850,8 @@
>  
>  	t->name = NULL;
>  	if (bs_debug) 
> -		fprintf(stderr, "trans init (%d,%d)\n", 
> -			t->stime, t->schema_number ); 
> +		fprintf(stderr, "trans (%p) init (%d,%d)\n", 
> +			t, t->stime, t->schema_number ); 
>  	return t;
>  }
>  
> @@ -2710,13 +2710,12 @@
>  			sql_schema *s = n->data;
>  			sql_schema *os;
>  
> -			
>  			if (isTempSchema(s))
>  				continue;
>  
>   			os = find_sql_schema(tr->parent, s->base.name);
>  			if (os/* || (s->base.wtime == 0 && s->base.rtime == 0)*/) {
> -				if (!validate_tables(s, os))
> +				if (!validate_tables(s, os)) 
>  					return 0;
>  			}
>  		}
> 
> 
> ------------------------------------------------------------------------------
> Stay on top of everything new and different, both inside and 
> around Java (TM) technology - register by April 22, and save
> $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
> 300 plus technical and hands-on sessions. Register today. 
> Use priority code J9JMT32. http://p.sf.net/sfu/p
> _______________________________________________
> Monetdb-sql-checkins mailing list
> Monetdb-sql-checkins at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins


-- 
Sjoerd Mullender




More information about the developers-list mailing list