[Monetdb-developers] [Monetdb-sql-checkins] sql/src/storage store.mx, Nov2008, 1.22.2.1, 1.22.2.2

Romulo Goncalves R.A.Goncalves at cwi.nl
Fri Nov 14 15:25:06 CET 2008


Sjoerd Mullender wrote:
> Romulo Goncalves wrote:
>> Update of /cvsroot/monetdb/sql/src/storage
>> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv25673
>>
>> Modified Files:
>>       Tag: Nov2008
>> 	store.mx 
>> Log Message:
>> I got the single thing....
>> Sorry the mistake...
> 
> This is exactly what I mean with being *very* conservative and being
> *absolutely* sure.  This error makes me very unhappy.
Optimized compilation did get it... Tests were all ok... I read 3 times 
the code and my eyes did not get it.

Romulo

> 
>> U store.mx
>> Index: store.mx
>> ===================================================================
>> RCS file: /cvsroot/monetdb/sql/src/storage/store.mx,v
>> retrieving revision 1.22.2.1
>> retrieving revision 1.22.2.2
>> diff -u -d -r1.22.2.1 -r1.22.2.2
>> --- store.mx	14 Nov 2008 13:46:52 -0000	1.22.2.1
>> +++ store.mx	14 Nov 2008 14:04:09 -0000	1.22.2.2
>> @@ -110,7 +110,7 @@
>>  	}
>>  	list_destroy(k->columns);
>>  	base_destroy(&k->base);
>> -	if ((k->type == pkey) && (k->t->pkey = (sql_ukey *) k))
>> +	if ((k->type == pkey) && (k->t->pkey == (sql_ukey *) k))
>>  		k->t->pkey = NULL;
>>  	_DELETE(k);
>>  }
>>
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Monetdb-sql-checkins mailing list
>> Monetdb-sql-checkins at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins
> 
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Monetdb-sql-checkins mailing list
> Monetdb-sql-checkins at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins





More information about the developers-list mailing list