[Monetdb-developers] MonetDB release planning

Stefan Manegold Stefan.Manegold at cwi.nl
Sun May 25 02:10:54 CEST 2008


On Sun, May 25, 2008 at 01:19:37AM +0200, Stefan de Konink wrote:
> Stefan Manegold schreef:
>> ( cd sql && cvs update )
>
> As real l33t h4x0r I changed the configure file by hand already. (And the 
> solution will probably only work in a few hours, pserver crap)
>
> But it seems mr-meltdown and my C compiler don't get along.
>
>
>
> gcc -DHAVE_CONFIG_H -I. -I../../.. -I. -I../../include -I./../../include 
> -I../../common -I./../../common -I../../storage -I./../../storage 
> -I../../server -I./../../server -I/opt/osm/include/MonetDB5/atoms 
> -I/opt/osm/include/MonetDB5/compiler -I/opt/osm/include/MonetDB5/kernel 
> -I/opt/osm/include/MonetDB5/mal -I/opt/osm/include/MonetDB5/optimizer 
> -I/opt/osm/include/MonetDB5/scheduler -I/opt/osm/include/MonetDB5 
> -I/opt/osm/include/MonetDB -I/opt/osm/include/MonetDB/mapilib 
> -I/opt/osm/include/MonetDB -I/opt/osm/include/MonetDB/common 
> -I/opt/osm/include/MonetDB/gdk    -g -O2 -Wall -Wextra -std=c99 
> -fgnu89-inline -Werror-implicit-function-declaration -Werror 
> -Wpointer-arith -Wdeclaration-after-statement -Wundef 
> -Wp,-D_FORTIFY_SOURCE=2 -c merovingian.c
> cc1: warnings being treated as errors
> merovingian.mx: In functie ‘discoveryRunner’:
> merovingian.mx:1336: let op: ‘sp’ is used uninitialized in this function
> merovingian.mx:1379: let op: ‘sp’ is used uninitialized in this function
>
>
> gcc --version
> gcc (GCC) 4.2.4 (Gentoo 4.2.4 p1.0)
>
>
> I could hack out the warning, only looking at the code, I wonder what is 
> actually wrong. The error complains about the declaration, and the first 
> use of the variable will initialize it.

(The compiler cannot see that the function will initialise the pointer!)


Please bear with us!
The problem was detected by last night's (Fri->Sat) testing, but could not
be fixed in CVS on Sat due to my "CVS lock" for creating the new release
branches.

1)
The problem should NOT occur if you use (as always recommended for non core
developers) the latest "Stable" branches instead of the "Current"
cutting-edge development trunk.

2)
With the development trunk, the problem should NOT occur if you configure with
"--disable-strict" (which is the default in the Stable branches.

3)
Attached patch prevents the problem.

Stefan

>
> Stefan

-- 
| Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4312       |
-------------- next part --------------
Index: src/backends/monet5/merovingian.mx
===================================================================
RCS file: /cvsroot/monetdb/sql/src/backends/monet5/merovingian.mx,v
retrieving revision 1.48
diff -u -r1.48 merovingian.mx
--- src/backends/monet5/merovingian.mx	23 May 2008 20:39:19 -0000	1.48
+++ src/backends/monet5/merovingian.mx	24 May 2008 16:55:53 -0000
@@ -1333,7 +1333,7 @@
 			/* LEAVE message, unregister database */
 			sabdb *rdb;
 			sabdb *prv;
-			char **sp;
+			char **sp = NULL;
 			char *dbname;
 			char *conn;
 
@@ -1376,7 +1376,7 @@
 			/* ANNOUNCE message, register database */
 			sabdb *rdb;
 			sablist *l;
-			char **sp;
+			char **sp = NULL;
 			char *dbname;
 			char *conn;
 			char *scens;


More information about the developers-list mailing list