[Monetdb-developers] [Monetdb-pf-checkins] pathfinder/runtime xrpc_common.mx, , 1.4, 1.5 xrpc_server.mx, , 1.77, 1.78

Stefan Manegold Stefan.Manegold at cwi.nl
Thu Jul 17 13:31:51 CEST 2008


On Thu, Jul 17, 2008 at 01:27:37PM +0200, Ying Zhang wrote:
> Hi Stefan,
> 
> You are right (again).  A small question:
> 
> >  @= xrpc_bat
> > -    xrpc_ at 1 = BATnew(TYPE_void,ATOMindex("@2"),1024);
> > -    assert(xrpc_ at 1);
> > -    BATseqbase(xrpc_ at 1, 1);
> > -    BBPrename(xrpc_ at 1->batCacheid, "xrpc_ at 1");
> > +    xrpc_bat = BATnew(TYPE_void,ATOMindex("@2"),1024);
> > +    assert(xrpc_bat);
> > +    BATseqbase(xrpc_bat, 1);
> > +    BBPrename(xrpc_bat->batCacheid, "xrpc_ at 1");
> >  @c
> >  
> >  bat* xrpc_prelude(void) {
> > +    BAT *xrpc_bat = NULL; 
> >      @:xrpc_bat(qids,str)@
> >      @:xrpc_bat(statuses,str)@
> >      @:xrpc_bat(timeouts,lng)@
> > @@ -886,7 +883,9 @@
> >      @:xrpc_bat(wsbats,bat)@
> >  
> >      @:xrpc_bat(trusted,str)@
> > +    xrpc_trusted = xrpc_bat;
> >      @:xrpc_bat(admin,str)@
> > +    xrpc_admin = xrpc_bat;
> 
> 
> Is there a particular reason to change this macro?

yes: use 1 local variable instead of 8 global variables.

Stefan

> Jennie
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Monetdb-developers mailing list
> Monetdb-developers at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-developers
> 

-- 
| Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4312       |




More information about the developers-list mailing list