[Monetdb-developers] [Monetdb-pf-checkins] pathfinder/modules/pftijah pftijah.mx, , 1.157, 1.158

Jan Flokstra flokstra at cs.utwente.nl
Wed Jan 2 09:00:23 CET 2008


On Monday 17 December 2007 18:55, Stefan Manegold wrote:
> On Tue, Dec 11, 2007 at 10:08:13AM +0000, Jan Flokstra wrote:
> > Update of /cvsroot/monetdb/pathfinder/modules/pftijah
> > In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv18823
> >
> > Modified Files:
> > 	pftijah.mx
> > Log Message:
> > - add an optional extra commit after document indexing to survey a bug
> >   where a server restart leads to a zero filled index bat.
>
> Just a stupid(?) question:
>
> In the code below, the "extra_commit" is initialized to "false", and never
> changed --- hence, the extra subcommit() in
> 	if ( extra_commit ) subcommit(_tj_collection_str(ftiName));
> is never called, right?
>
> Hence, what is/was the intention/need of this checkin?
>

The checkin was done because Roberto had a problem with unexpected zeros in 
BAT's after an Mserver restart. I asked him to run the Mserver with the 
extra_commit variable set to true and look what happens,

Happy New Year, Jan.


> Stefan
>
> > Index: pftijah.mx
> > ===================================================================
> > RCS file: /cvsroot/monetdb/pathfinder/modules/pftijah/pftijah.mx,v
> > retrieving revision 1.157
> > retrieving revision 1.158
> > diff -u -d -r1.157 -r1.158
> > --- pftijah.mx	4 Oct 2007 10:41:12 -0000	1.157
> > +++ pftijah.mx	11 Dec 2007 10:08:09 -0000	1.158
> > @@ -315,7 +315,9 @@
> >  #                                                                   #
> >  #####################################################################
> >
> > -var verbose := false;
> > +var verbose      := false;
> > +
> > +var extra_commit := false;
> >
> >  const dflt_ft_index   := "DFLT_FT_INDEX";
> >  const dflt_bg_index   := "DFLT_FT_INDEX";
> > @@ -997,6 +999,7 @@
> >        _tj_add2collection(ftiName, collBat, uri_loc, uri_name, store);
> >        _tj_finalize_collection(ftiName, collBat, FALSE);
> >        _tj_commit(collBat);
> > +      if ( extra_commit ) subcommit(_tj_collection_str(ftiName));
> >        if ( timing ) {
> >           var ms := (usec()-t_start)/1000;
> >           printf("#C[%s]:tj_add2collection(): + aggregate time =
> > %lld.%03llds.\n",ftiName,/(ms,1000),%(ms,1000)); @@ -1038,6 +1041,7 @@
> >           printf("#C[%s]:tj_add2collection(BAT): + aggregate time =
> > %lld.%03llds.\n",ftiName,/(ms,1000),%(ms,1000)); }
> >        _tj_commit(collBat);
> > +      if ( extra_commit ) subcommit(_tj_collection_str(ftiName));
> >      });
> >      lock_unset(coll_lock);
> >      if (not(isnil(err))) ERROR(err);
> >
> >
> > -------------------------------------------------------------------------
> > SF.Net email is sponsored by:
> > Check out the new SourceForge.net Marketplace.
> > It's the best place to buy or sell services for
> > just about anything Open Source.
> > http://sourceforge.net/services/buy/index.php
> > _______________________________________________
> > Monetdb-pf-checkins mailing list
> > Monetdb-pf-checkins at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins




More information about the developers-list mailing list