[Monetdb-developers] [Monetdb-pf-checkins] pathfinder/compiler/semantics heuristic.c

Stefan Manegold Stefan.Manegold at cwi.nl
Wed Sep 12 22:15:44 CEST 2007


On Wed, Sep 12, 2007 at 09:54:45AM +0200, Jan Rittinger wrote:
> Hi Peter,
> 
> I have two small comments to your changes:
> 
> 1. Is there a reason for including monet_utils.h here? -- In my eyes it 
> introduces an unnecessary dependency to MonetDB (as we want the SQL code 
> generation to compile even without MonetDB).

milprint_summer.c seems to compile fine without monet_utils.h;
hence, I removed it again.

Stefan

> Index: milprint_summer.c
> ===================================================================
> RCS file: /cvsroot/monetdb/pathfinder/compiler/mil/milprint_summer.c,v
> retrieving revision 1.404
> retrieving revision 1.405
> diff -u -d -r1.404 -r1.405
> --- milprint_summer.c	5 Sep 2007 17:06:54 -0000	1.404
> +++ milprint_summer.c	11 Sep 2007 22:15:29 -0000	1.405
> @@ -56,6 +56,7 @@
>   #define USE_DEPRECATED_ACCESS_TO_TYPE_SYSTEM 1
> 
>   #include "pathfinder.h"
> +#include "monet_utils.h"
> 
>   #include <stdio.h>
>   #include <assert.h>

-- 
| Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4312       |




More information about the developers-list mailing list