[Monetdb-developers] [Monetdb-checkins] MonetDB/src/gdk gdk_utils.mx, , 1.196, 1.197

Sjoerd Mullender sjoerd at acm.org
Wed Nov 28 13:48:10 CET 2007


Please revert.

This is not the solution.  It is also *blatantly* untrue that nobody
cares.  We (at least Niels, Stefan, and I--we didn't discuss this with
Peter) do care, but we want a proper solution, and this is not it.  We
agree that there should not be a call to umask in the code, but we
should also check the modes that are used in calls to creat, open,
mkdir, etc.

If you think this umask thing is important for you, say so in the bug
report and increase the priority accordingly.  You can also *talk* to
people if something is important to you.

Fabian wrote:
> Update of /cvsroot/monetdb/MonetDB/src/gdk
> In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv7068
> 
> Modified Files:
> 	gdk_utils.mx 
> Log Message:
> Because nobody cares but me.
> Don't wipe out the user's umask if gdk_dont_unset_umask is set in the
> environment.  Can't use GDKgetenv as that stuff is not yet initialised
> at this point.
> 
> 
> Index: gdk_utils.mx
> ===================================================================
> RCS file: /cvsroot/monetdb/MonetDB/src/gdk/gdk_utils.mx,v
> retrieving revision 1.196
> retrieving revision 1.197
> diff -u -d -r1.196 -r1.197
> --- gdk_utils.mx	14 Nov 2007 13:22:59 -0000	1.196
> +++ gdk_utils.mx	28 Nov 2007 11:59:39 -0000	1.197
> @@ -1636,7 +1636,8 @@
>  	if (GDKrecovery && unlink(GDKLOCK) < 0) {
>  		GDKfatal("GDKlockHome: unlock DB failed\n");
>  	}
> -	umask(0000);
> +	if (getenv("gdk_dont_unset_umask") == NULL)
> +		umask(0000);
>  	if (MT_lockf(GDKLOCK, F_TLOCK, 4, 1) < 0) {
>  		GDKlockFile = 0;
>  		GDKfatal("GDKlockHome: Database lock '%s' denied\n", GDKLOCK);
> 
> 
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> Monetdb-checkins mailing list
> Monetdb-checkins at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins


-- 
Sjoerd Mullender

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 370 bytes
Desc: OpenPGP digital signature
URL: <http://www.monetdb.org/pipermail/developers-list/attachments/20071128/f431bc13/attachment.sig>


More information about the developers-list mailing list