[Monetdb-developers] [Monetdb-pf-checkins] pathfinder/src/tools/java build.properties, XQuery_0-20, 1.1.2.3, 1.1.2.4

Ying Zhang Y.Zhang at cwi.nl
Thu Nov 1 13:42:15 CET 2007


On Thu, Nov 01, 2007 at 01:33:06PM +0100, Stefan Manegold wrote:
> Jennie,
> 
> just out of "pure curiosity":
> 
> had you been able to compile your original version (that failed to compile
> with testing on all platforms) prior to checking it in?

I did compile the java source code.  My mistake was that I did not check
the build.property before checkin: I set build_compiler to 'gcj' to
check if the code compiles with gcj, after that I changed build_compiler
to 'javac' since it should be used as default, but then, I didn't
recompile...

Jennie

> 
> Stefan
> 
> On Thu, Nov 01, 2007 at 01:27:40PM +0100, Ying Zhang wrote:
> > On Thu, Nov 01, 2007 at 12:30:31PM +0100, Fabian Groffen wrote:
> > > On 01-11-2007 10:48:18 +0000, Ying Zhang wrote:
> > > > Update of /cvsroot/monetdb/pathfinder/src/tools/java
> > > > In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5671
> > > > 
> > > > Modified Files:
> > > >       Tag: XQuery_0-20
> > > > 	build.properties 
> > > > Log Message:
> > > > Corrected value of the "compiler" attribute of <javac>
> > > [snip]
> > > >  # which Java compiler to use, default: javac
> > > > -build_compiler=javac
> > > > +build_compiler=javac1.5
> > > 
> > > While the comment doesn't reflect a valid state here, this isn't too
> > > flexible.  Why don't you just drop the whole build_compiler variable you
> > > introduced, and use the completely transparent and well supported and
> > > usually expected build.compiler variable only once you really want to
> > > control what compiler is being used, as I suggested to you earlier?
> > 
> > Just because I haven't read your previous mail before commit the change.
> > Hence, thanks for the suggestion, and I will change it again.
> > 
> > Jennie
> 
> -- 
> | Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
> | CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
> | 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
> | The Netherlands     | Fax : +31 (20) 592-4312       |
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> Monetdb-developers mailing list
> Monetdb-developers at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-developers




More information about the developers-list mailing list