[Monetdb-developers] [Monetdb-pf-checkins] pathfinder/modules/pftijah pftijah.mx, XQuery_0-18, 1.134.2.1, 1.134.2.2

Stefan Manegold Stefan.Manegold at cwi.nl
Thu Jun 7 12:08:40 CEST 2007


Jan,

IMHO, this changes is not correct.

Though being of type BIT (which is physically a signed char, hence 8 bit
wide), the ordered flags use all 8 bits, only the lowest one (1) indicates
sortedness, the highest one (1<<7=128) indicates reverse sortedness, and the
remaining ones are "mis-"used for radix clustering.

Hence, checking for sortedness shoudl alwasy be done with
BAT[ht]ordered(b)&1 --- regardless of the endianess, this should alwasy
check for the lowest bit, now matter whether this is located left or right
--- anyway, endianess is about byte orde, not about bit order, right??

Hence, if the your change does fix the Itanium problems, than the bug is
IMHO caused somewhere else (wrong setting of the ordered flag?), and only
appears here...

Stefan

On Thu, Jun 07, 2007 at 09:28:20AM +0000, Jan Flokstra wrote:
> Update of /cvsroot/monetdb/pathfinder/modules/pftijah
> In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv29459
> 
> Modified Files:
>       Tag: XQuery_0-18
> 	pftijah.mx 
> Log Message:
> - Try to fix Itanium bug [ 1732596 ] PFtijah tests fail on Itanium
>   Remove the bitwise AND in the check because it could be at the wrong side
>   of the word?
> 
> 
> 
> Index: pftijah.mx
> ===================================================================
> RCS file: /cvsroot/monetdb/pathfinder/modules/pftijah/pftijah.mx,v
> retrieving revision 1.134.2.1
> retrieving revision 1.134.2.2
> diff -u -d -r1.134.2.1 -r1.134.2.2
> --- pftijah.mx	4 Jun 2007 17:42:06 -0000	1.134.2.1
> +++ pftijah.mx	7 Jun 2007 09:28:18 -0000	1.134.2.2
> @@ -3745,8 +3745,10 @@
>  	/* --------------------------- checks ---------------------------------- */
>  
>  	BATcheck(tid, name);
> -	if (!(BATtordered(tid) & 1))
> +	/* if (!(BATtordered(tid) & 1)) */
> +	if ( !(BATtordered(tid) )
>  	{
> +		/* BUG#1732596 this test currently fails on Itanium */
>          	GDKerror("%s: index-bat must be ordered on tail.\n", name);
>      		return GDK_FAIL;
>  	}
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Monetdb-pf-checkins mailing list
> Monetdb-pf-checkins at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
> 

-- 
| Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4312       |




More information about the developers-list mailing list