[Monetdb-developers] ALLREADY_HAVE_WINDOWS_TYPE vs. ALREADY_HAVE_WINDOWS_TYPE

Stefan Manegold Stefan.Manegold at cwi.nl
Wed Jan 10 20:44:30 CET 2007


On Wed, Jan 10, 2007 at 08:42:36PM +0100, Sjoerd Mullender wrote:
> On 01/10/2007 07:38 PM, Stefan Manegold wrote:
> > On Wed, Jan 10, 2007 at 02:38:34PM +0100, Fabian Groffen wrote:
> >> On 10-01-2007 13:36:17 +0000, Sjoerd Mullender wrote:
> >>> /* Define to `unsigned' if <sys/types.h> does not define. */
> >>> /* #undef size_t */
> >>>
> >>> #define ALLREADY_HAVE_WINDOWS_TYPE
> >> is this intentional, or a typo?
> > 
> > we have/use "ALREADY_HAVE_WINDOWS_TYPE" in
> >               ^
> > Stable/sql/src/odbc/winsetup/setup.c:#define ALREADY_HAVE_WINDOWS_TYPE
> > Stable/sql/src/odbc/driver/ODBCGlobal.h:#define ALREADY_HAVE_WINDOWS_TYPE
> > Stable/sql/src/odbc/include/sqltypes.h:#ifndef ALREADY_HAVE_WINDOWS_TYPE
> > Stable/sql/src/odbc/include/sqltypes.h:#ifndef ALREADY_HAVE_WINDOWS_TYPE
> > Stable/sql/src/odbc/include/sqltypes.h:#ifndef ALREADY_HAVE_WINDOWS_TYPE
> > Current/MonetDB/conf/MonetDB.m4:      AC_DEFINE([ALREADY_HAVE_WINDOWS_TYPE], ,
> > Current/clients/NT/clients_config.h.in:#define ALREADY_HAVE_WINDOWS_TYPE 1
> > Current/clients/src/odbc/winsetup/setup.c:#define ALREADY_HAVE_WINDOWS_TYPE
> > Current/clients/src/odbc/driver/ODBCGlobal.h:#define ALREADY_HAVE_WINDOWS_TYPE 1
> > Current/clients/src/odbc/include/sqltypes.h:#ifndef ALREADY_HAVE_WINDOWS_TYPE
> > Current/clients/src/odbc/include/sqltypes.h:#ifndef ALREADY_HAVE_WINDOWS_TYPE
> > Current/clients/src/odbc/include/sqltypes.h:#ifndef ALREADY_HAVE_WINDOWS_TYPE
> > 
> > 
> > but "ALLREADY_HAVE_WINDOWS_TYPE" in
> >       ^^
> > Stable/sql/NT/winconfig.h:#define ALLREADY_HAVE_WINDOWS_TYPE
> > Stable/MonetDB/sysdefs.h.in:#define ALLREADY_HAVE_WINDOWS_TYPE
> > Current/sql/NT/sql_config.h.in:#define ALLREADY_HAVE_WINDOWS_TYPE
> > Current/amdb/NT/winconfig.h:#define ALLREADY_HAVE_WINDOWS_TYPE
> > Current/MonetDB5/NT/mal_config.h.in:#define ALLREADY_HAVE_WINDOWS_TYPE
> > Current/MonetDB4/sysdefs.h.in:#define ALLREADY_HAVE_WINDOWS_TYPE
> > Current/clients/clients_config.h.in:#undef ALLREADY_HAVE_WINDOWS_TYPE
> > 
> > 
> > Am I right that the latter are a typo and should read
> > "ALREADY_HAVE_WINDOWS_TYPE", just like the former?
> > 
> > 
> > Stefan
> > 
> > 
> 
> It should be with 1 L everywhere.  It's used like that in sqltypes.h.

ok. You or me?

Stefan

> Sjoerd Mullender

-- 
| Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4312       |




More information about the developers-list mailing list