[Monetdb-developers] [Monetdb-checkins] clients/src/mapiclient MapiClient.mx, , 1.41, 1.42

Martin Kersten Martin.Kersten at cwi.nl
Wed Aug 15 13:55:00 CEST 2007


Fabian Groffen wrote:
> On 15-08-2007 11:24:47 +0000, Martin Kersten wrote:
>> -				case 'e':
>> +				case 'E':
>>  					echoquery = 1;
>>  					continue;
>>  				case 'f':
>> @@ -1253,7 +1243,7 @@
>>  					setFormatter(s);
>>  					continue;
>>  				}
>> -				case 'x':
>> +				case 'e':
>>  					exit_on_error = 1;
> 
> I suggest haveing -e for echo.
> 
> exit_on_error should not be necessary, if you assume the following:
> 1) the language being used has control for errors itself, e.g. SQL's
>    auto-commit, or
> 2) an error should not happen in batches, thus
> 3) the client continues executing when reading from stdin, but dies on
>    the first error when reading from file
> 
> Don't know how much this would affect testweb, but somewhere I feel it
> is only in an interactive session sensible to continue after an error.
According to Stefan this does not affect the test web.

The feature will be dropped on the next commit




More information about the developers-list mailing list