[Monetdb-developers] [PATCH] Loop Lifted Pathfinder sources

Stefan Manegold Stefan.Manegold at cwi.nl
Fri Nov 3 16:18:41 CET 2006


Hi All,

I tried to apply Fabian's patches, but cannot check them in, yet.


First, I had to fix the patches, to get the code compiled with icc.
Basically, icc (correctly) complained about code like

	switch (n->kind) {
	unsigned int col = 0, row = 0;

	case la_lit_tbl:
		...
	}

with
========
/net/corona.ins.cwi.nl/export/scratch0/manegold/Monet/Testing/Current/pathfinder/compiler/algebra/prop/prop_const.c(305): error #185: dynamic initialization in unreachable code
          unsigned int col = 0, row = 0;
                       ^

/net/corona.ins.cwi.nl/export/scratch0/manegold/Monet/Testing/Current/pathfinder/compiler/algebra/prop/prop_const.c(304): error #589: transfer of control bypasses initialization of:
            variable "col" (declared at line 305)
            variable "row" (declared at line 305)
      switch (n->kind) {
      ^

compilation aborted for /net/corona.ins.cwi.nl/export/scratch0/manegold/Monet/Testing/Current/pathfinder/compiler/algebra/prop/prop_const.c (code 2)
make[8]: *** [libprop_la-prop_const.lo] Error 1
========


Second, the patch seem to break the algebra implementation --- most algebra
tests and some more test fail with the patch applied, while they don't
without.


Hence, finally applying these patches will require some more time-consuming
debugging --- but not tonight --- actually, I cannot tell, yet, when I'll
have time for that ...


Stefan


On Fri, Nov 03, 2006 at 10:38:19AM +0100, Torsten Grust wrote:
> Hi Niels,
> 
>    we are fine with the integration of this patch.
> 
> Cheers,
>     --Teggy
> 
> On Nov 3, 2006, 10:24 AM, Niels Nes wrote with possible deletions:
> > [...]
> > We know (now) that this patch doesn't solve the C99 issues. But this
> > patch makes it possible as fabian pointed out to compile all  
> > components
> > of MonetDB without extra gcc options on Gentoo. This will make it much
> > easier to maintain the MonetDB product family on Gentoo, which is  
> > currently
> > the costing way to much time (without any payback (ie not used  
> > because it
> > breaks way to many times)).
> >
> > Therefor we still would like to integrate this patch. Any objections?
> 
> -- 
> | Torsten Grust
> | torsten.grust at gmail.com
> 
> 
> 
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Monetdb-developers mailing list
> Monetdb-developers at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-developers
> 

-- 
| Dr. Stefan Manegold | mailto:Stefan.Manegold at cwi.nl |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4312       |




More information about the developers-list mailing list