Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/modules/pftijah/Tests procs.stable.out, , 1.29, 1.30
Henning,
thanks for being aware of stable output and maitaining int accoring to your changes.
However, did you change the signatures of PROCs client(), descendant(), descendant_or_self(), ll_child(), ll_descendant(), ll_descendant_or_self(), preceding(), preceding_sibling() in addition to vx_maintain()?
I cannot see any comment in your checkin message, nor did I find any hint in the diffs.
Hence, why did you change the respective stable output, then?
Well, to solve the "riddle" (addressing all of you, not only Henning!): when updating stable output, please make sure that (1) either your code base is indeed up-to-date, or that (2) you change only those parts of stable output which actually relate to your code changes.
Stable output is even more important and sensitive than the actual code --- it is used to test the correctness of the actual code. Hence, please treat it with the respective concentration and care.
Thanks.
Stefan
On Wed, Sep 05, 2007 at 03:41:57PM +0000, Henning Rode wrote:
Update of /cvsroot/monetdb/pathfinder/modules/pftijah/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv12978/Tests
Modified Files: procs.stable.out Log Message: bug-fix in multiplicative retrieval models (thanks djoerd for finding it. in those models, the number a term occurs in a query becomes an exponent in the score function (not a factor)).
Index: procs.stable.out
RCS file: /cvsroot/monetdb/pathfinder/modules/pftijah/Tests/procs.stable.out,v retrieving revision 1.29 retrieving revision 1.30 diff -u -d -r1.29 -r1.30 --- procs.stable.out 1 Sep 2007 11:34:18 -0000 1.29 +++ procs.stable.out 5 Sep 2007 15:41:55 -0000 1.30 @@ -137,7 +137,6 @@ [ "ceil(flt) : flt" ] [ "checkpoint_protect(BAT[void,BAT]) : void" ] [ "checkpoint_unprotect(BAT[void,BAT]) : void" ] -[ "child(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "child(BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "clear(BAT[any::1,any::2]) : BAT[any::1,any::2]" ] [ "clients() : void" ] @@ -173,9 +172,7 @@ [ "delete_doc(BAT[void,str]) : void" ] [ "delete_doc(str) : void" ] [ "delete_pfc_fti(str) : void" ] -[ "descendant(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "descendant(BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] -[ "descendant_or_self(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "descendant_or_self(BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "destroy(BAT[any,any]) : bit" ] [ "diff(BAT[any::1,any::2], BAT[any::1,any::2]) : BAT[any::1,any::2]" ] @@ -271,9 +268,6 @@ [ "listen(int, int) : void" ] [ "listen(int, int, bit) : void" ] [ "listen(int, str, int) : void" ] -[ "ll_child(BAT[oid,oid], BAT[oid,oid], BAT[oid,int], BAT[void,any], bit, bit, oid, oid, bit, chr) : BAT[oid,oid]" ] -[ "ll_descendant(BAT[oid,oid], BAT[oid,oid], BAT[oid,int], BAT[void,any], bit, bit, oid, oid, bit, chr) : BAT[oid,oid]" ] -[ "ll_descendant_or_self(BAT[oid,oid], BAT[oid,oid], BAT[oid,int], BAT[void,any], bit, bit, oid, oid, bit, chr) : BAT[oid,oid]" ] [ "ll_htordered_unique_thetajoin(int, BAT[oid,any::2], BAT[oid,any::2], BAT[void,oid], BAT[void,oid], any, any) : BAT[any,any]" ] [ "ll_standoff_select_narrow(BAT[void,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,any], BAT[oid,any]) : BAT[oid,oid]" ] [ "ll_standoff_select_wide(BAT[void,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,any], BAT[oid,any]) : BAT[oid,oid]" ] @@ -490,8 +484,9 @@ [ "pi() : dbl" ] [ "play_doc_tape(BAT[void,BAT], BAT[void,oid], BAT[void,int], BAT[void,lng], BAT[void,str]) : void" ] [ "play_update_tape(BAT[void,BAT], BAT[void,oid], BAT[void,int], BAT[void,lng], BAT[void,str]) : void" ] +[ "preceding(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int) : BAT[void,BAT]" ] [ "preceding(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int, chr) : BAT[void,BAT]" ] -[ "preceding_sibling(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int, chr) : BAT[void,BAT]" ] +[ "preceding_sibling(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int) : BAT[void,BAT]" ] [ "print(str, BAT[any::1,any], ..BAT[any::1,any]..) : void" ] [ "prior_logls(BAT[any,any], int, BAT[oid,str]) : BAT[any,any]" ] [ "prior_ls(BAT[any,any], int, BAT[oid,str]) : BAT[any,any]" ] @@ -652,7 +647,7 @@ [ "vm_usage(int) : BAT[str,lng]" ] [ "vx_lookup(BAT[void,BAT], BAT[void,oid], BAT[void,int], BAT[void,str], str, str, bit) : BAT[oid,oid]" ] [ "vx_lookup(BAT[void,BAT], oid, BAT[void,str], str, str, bit) : BAT[oid,oid]" ] -[ "vx_maintain(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,str]) : BAT[int,oid]" ] +[ "vx_maintain(BAT[oid,oid], BAT[oid,oid], BAT[oid,str]) : BAT[int,oid]" ] [ "vx_maintain(BAT[oid,oid], BAT[oid,str]) : BAT[int,oid]" ] [ "vx_reduce(BAT[oid,int], BAT[void,oid]) : BAT[oid,oid]" ] [ "ws_collection(BAT[void,BAT], BAT[oid,str], BAT[void,oid]) : BAT[oid,oid]" ]
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
ok, sorry. of course i have not changed all that PROCs. i always thought that PROCs test only meant all PROCs in our module, but that is apparently not the case. i'll take care next time.
-henning
Stefan Manegold wrote:
Henning,
thanks for being aware of stable output and maitaining int accoring to your changes.
However, did you change the signatures of PROCs client(), descendant(), descendant_or_self(), ll_child(), ll_descendant(), ll_descendant_or_self(), preceding(), preceding_sibling() in addition to vx_maintain()?
I cannot see any comment in your checkin message, nor did I find any hint in the diffs.
Hence, why did you change the respective stable output, then?
Well, to solve the "riddle" (addressing all of you, not only Henning!): when updating stable output, please make sure that (1) either your code base is indeed up-to-date, or that (2) you change only those parts of stable output which actually relate to your code changes.
Stable output is even more important and sensitive than the actual code --- it is used to test the correctness of the actual code. Hence, please treat it with the respective concentration and care.
Thanks.
Stefan
On Wed, Sep 05, 2007 at 03:41:57PM +0000, Henning Rode wrote:
Update of /cvsroot/monetdb/pathfinder/modules/pftijah/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv12978/Tests
Modified Files: procs.stable.out Log Message: bug-fix in multiplicative retrieval models (thanks djoerd for finding it. in those models, the number a term occurs in a query becomes an exponent in the score function (not a factor)).
Index: procs.stable.out
RCS file: /cvsroot/monetdb/pathfinder/modules/pftijah/Tests/procs.stable.out,v retrieving revision 1.29 retrieving revision 1.30 diff -u -d -r1.29 -r1.30 --- procs.stable.out 1 Sep 2007 11:34:18 -0000 1.29 +++ procs.stable.out 5 Sep 2007 15:41:55 -0000 1.30 @@ -137,7 +137,6 @@ [ "ceil(flt) : flt" ] [ "checkpoint_protect(BAT[void,BAT]) : void" ] [ "checkpoint_unprotect(BAT[void,BAT]) : void" ] -[ "child(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "child(BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "clear(BAT[any::1,any::2]) : BAT[any::1,any::2]" ] [ "clients() : void" ] @@ -173,9 +172,7 @@ [ "delete_doc(BAT[void,str]) : void" ] [ "delete_doc(str) : void" ] [ "delete_pfc_fti(str) : void" ] -[ "descendant(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "descendant(BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] -[ "descendant_or_self(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "descendant_or_self(BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "destroy(BAT[any,any]) : bit" ] [ "diff(BAT[any::1,any::2], BAT[any::1,any::2]) : BAT[any::1,any::2]" ] @@ -271,9 +268,6 @@ [ "listen(int, int) : void" ] [ "listen(int, int, bit) : void" ] [ "listen(int, str, int) : void" ] -[ "ll_child(BAT[oid,oid], BAT[oid,oid], BAT[oid,int], BAT[void,any], bit, bit, oid, oid, bit, chr) : BAT[oid,oid]" ] -[ "ll_descendant(BAT[oid,oid], BAT[oid,oid], BAT[oid,int], BAT[void,any], bit, bit, oid, oid, bit, chr) : BAT[oid,oid]" ] -[ "ll_descendant_or_self(BAT[oid,oid], BAT[oid,oid], BAT[oid,int], BAT[void,any], bit, bit, oid, oid, bit, chr) : BAT[oid,oid]" ] [ "ll_htordered_unique_thetajoin(int, BAT[oid,any::2], BAT[oid,any::2], BAT[void,oid], BAT[void,oid], any, any) : BAT[any,any]" ] [ "ll_standoff_select_narrow(BAT[void,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,any], BAT[oid,any]) : BAT[oid,oid]" ] [ "ll_standoff_select_wide(BAT[void,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,any], BAT[oid,any]) : BAT[oid,oid]" ] @@ -490,8 +484,9 @@ [ "pi() : dbl" ] [ "play_doc_tape(BAT[void,BAT], BAT[void,oid], BAT[void,int], BAT[void,lng], BAT[void,str]) : void" ] [ "play_update_tape(BAT[void,BAT], BAT[void,oid], BAT[void,int], BAT[void,lng], BAT[void,str]) : void" ] +[ "preceding(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int) : BAT[void,BAT]" ] [ "preceding(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int, chr) : BAT[void,BAT]" ] -[ "preceding_sibling(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int, chr) : BAT[void,BAT]" ] +[ "preceding_sibling(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int) : BAT[void,BAT]" ] [ "print(str, BAT[any::1,any], ..BAT[any::1,any]..) : void" ] [ "prior_logls(BAT[any,any], int, BAT[oid,str]) : BAT[any,any]" ] [ "prior_ls(BAT[any,any], int, BAT[oid,str]) : BAT[any,any]" ] @@ -652,7 +647,7 @@ [ "vm_usage(int) : BAT[str,lng]" ] [ "vx_lookup(BAT[void,BAT], BAT[void,oid], BAT[void,int], BAT[void,str], str, str, bit) : BAT[oid,oid]" ] [ "vx_lookup(BAT[void,BAT], oid, BAT[void,str], str, str, bit) : BAT[oid,oid]" ] -[ "vx_maintain(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,str]) : BAT[int,oid]" ] +[ "vx_maintain(BAT[oid,oid], BAT[oid,oid], BAT[oid,str]) : BAT[int,oid]" ] [ "vx_maintain(BAT[oid,oid], BAT[oid,str]) : BAT[int,oid]" ] [ "vx_reduce(BAT[oid,int], BAT[void,oid]) : BAT[oid,oid]" ] [ "ws_collection(BAT[void,BAT], BAT[oid,str], BAT[void,oid]) : BAT[oid,oid]" ]
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
On Wed, Sep 05, 2007 at 07:53:19PM +0200, Henning Rode wrote:
ok, sorry. of course i have not changed all that PROCs. i always thought that PROCs test only meant all PROCs in our module, but that is apparently not the case. i'll take care next time.
Ok --- and who's going to undo your accidental changes before we forget about it? you, me, ... ?
Stefan
-henning
Stefan Manegold wrote:
Henning,
thanks for being aware of stable output and maitaining int accoring to your changes.
However, did you change the signatures of PROCs client(), descendant(), descendant_or_self(), ll_child(), ll_descendant(), ll_descendant_or_self(), preceding(), preceding_sibling() in addition to vx_maintain()?
I cannot see any comment in your checkin message, nor did I find any hint in the diffs.
Hence, why did you change the respective stable output, then?
Well, to solve the "riddle" (addressing all of you, not only Henning!): when updating stable output, please make sure that (1) either your code base is indeed up-to-date, or that (2) you change only those parts of stable output which actually relate to your code changes.
Stable output is even more important and sensitive than the actual code --- it is used to test the correctness of the actual code. Hence, please treat it with the respective concentration and care.
Thanks.
Stefan
On Wed, Sep 05, 2007 at 03:41:57PM +0000, Henning Rode wrote:
Update of /cvsroot/monetdb/pathfinder/modules/pftijah/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv12978/Tests
Modified Files: procs.stable.out Log Message: bug-fix in multiplicative retrieval models (thanks djoerd for finding it. in those models, the number a term occurs in a query becomes an exponent in the score function (not a factor)).
Index: procs.stable.out
RCS file: /cvsroot/monetdb/pathfinder/modules/pftijah/Tests/procs.stable.out,v retrieving revision 1.29 retrieving revision 1.30 diff -u -d -r1.29 -r1.30 --- procs.stable.out 1 Sep 2007 11:34:18 -0000 1.29 +++ procs.stable.out 5 Sep 2007 15:41:55 -0000 1.30 @@ -137,7 +137,6 @@ [ "ceil(flt) : flt" ] [ "checkpoint_protect(BAT[void,BAT]) : void" ] [ "checkpoint_unprotect(BAT[void,BAT]) : void" ] -[ "child(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "child(BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "clear(BAT[any::1,any::2]) : BAT[any::1,any::2]" ] [ "clients() : void" ] @@ -173,9 +172,7 @@ [ "delete_doc(BAT[void,str]) : void" ] [ "delete_doc(str) : void" ] [ "delete_pfc_fti(str) : void" ] -[ "descendant(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "descendant(BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] -[ "descendant_or_self(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "descendant_or_self(BAT[oid,oid], BAT[oid,oid], oid, BAT[oid,BAT], int, BAT[void,any], chr) : BAT[void,BAT]" ] [ "destroy(BAT[any,any]) : bit" ] [ "diff(BAT[any::1,any::2], BAT[any::1,any::2]) : BAT[any::1,any::2]" ] @@ -271,9 +268,6 @@ [ "listen(int, int) : void" ] [ "listen(int, int, bit) : void" ] [ "listen(int, str, int) : void" ] -[ "ll_child(BAT[oid,oid], BAT[oid,oid], BAT[oid,int], BAT[void,any], bit, bit, oid, oid, bit, chr) : BAT[oid,oid]" ] -[ "ll_descendant(BAT[oid,oid], BAT[oid,oid], BAT[oid,int], BAT[void,any], bit, bit, oid, oid, bit, chr) : BAT[oid,oid]" ] -[ "ll_descendant_or_self(BAT[oid,oid], BAT[oid,oid], BAT[oid,int], BAT[void,any], bit, bit, oid, oid, bit, chr) : BAT[oid,oid]" ] [ "ll_htordered_unique_thetajoin(int, BAT[oid,any::2], BAT[oid,any::2], BAT[void,oid], BAT[void,oid], any, any) : BAT[any,any]" ] [ "ll_standoff_select_narrow(BAT[void,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,any], BAT[oid,any]) : BAT[oid,oid]" ] [ "ll_standoff_select_wide(BAT[void,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,any], BAT[oid,any]) : BAT[oid,oid]" ] @@ -490,8 +484,9 @@ [ "pi() : dbl" ] [ "play_doc_tape(BAT[void,BAT], BAT[void,oid], BAT[void,int], BAT[void,lng], BAT[void,str]) : void" ] [ "play_update_tape(BAT[void,BAT], BAT[void,oid], BAT[void,int], BAT[void,lng], BAT[void,str]) : void" ] +[ "preceding(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int) : BAT[void,BAT]" ] [ "preceding(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int, chr) : BAT[void,BAT]" ] -[ "preceding_sibling(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int, chr) : BAT[void,BAT]" ] +[ "preceding_sibling(BAT[void,oid], BAT[void,oid], oid, BAT[void,BAT], int) : BAT[void,BAT]" ] [ "print(str, BAT[any::1,any], ..BAT[any::1,any]..) : void" ] [ "prior_logls(BAT[any,any], int, BAT[oid,str]) : BAT[any,any]" ] [ "prior_ls(BAT[any,any], int, BAT[oid,str]) : BAT[any,any]" ] @@ -652,7 +647,7 @@ [ "vm_usage(int) : BAT[str,lng]" ] [ "vx_lookup(BAT[void,BAT], BAT[void,oid], BAT[void,int], BAT[void,str], str, str, bit) : BAT[oid,oid]" ] [ "vx_lookup(BAT[void,BAT], oid, BAT[void,str], str, str, bit) : BAT[oid,oid]" ] -[ "vx_maintain(BAT[oid,oid], BAT[oid,oid], BAT[oid,oid], BAT[oid,str]) : BAT[int,oid]" ] +[ "vx_maintain(BAT[oid,oid], BAT[oid,oid], BAT[oid,str]) : BAT[int,oid]" ] [ "vx_maintain(BAT[oid,oid], BAT[oid,str]) : BAT[int,oid]" ] [ "vx_reduce(BAT[oid,int], BAT[void,oid]) : BAT[oid,oid]" ] [ "ws_collection(BAT[void,BAT], BAT[oid,str], BAT[void,oid]) : BAT[oid,oid]" ]
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
participants (2)
-
Henning Rode -
Stefan Manegold