Re: [Monetdb-developers] [Monetdb-checkins] MonetDB configure.ag, Nov2009, 1.208.2.2, 1.208.2.3
On Thu, Nov 12, 2009 at 09:06:23AM +0000, Fabian wrote:
Update of /cvsroot/monetdb/MonetDB In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv25980
Modified Files: Tag: Nov2009 configure.ag Log Message: Yippy yay for messing with this at this stage of the development cycle... Revert my yesterday's commit here as it not only breaks compilation on OSX 10.6 (the original problem), but also Solaris 10. We need to facilitate people doing cross-compilation in some other way.
Might simply using AC_CHECK_FUNCS(fdatasync) be an option, here?
Stefan
Index: configure.ag
RCS file: /cvsroot/monetdb/MonetDB/configure.ag,v retrieving revision 1.208.2.2 retrieving revision 1.208.2.3 diff -u -d -r1.208.2.2 -r1.208.2.3 --- configure.ag 11 Nov 2009 11:17:52 -0000 1.208.2.2 +++ configure.ag 12 Nov 2009 09:06:21 -0000 1.208.2.3 @@ -94,17 +94,15 @@
# Checks for library functions.
-# OSX 10.6 (Snow Leopard) somehow makes configure believe that fdatasync -# exists, in reality however, it does not on this platform. -AC_CACHE_CHECK([for fdatasync],[ac_cv_func_fdatasync],[
- AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
+# Fix for OSX 10.6 (Snow Leopard) stolen from: +# http://blogs.sun.com/elambert/entry/drizzle_in_the_snow_how +AC_RUN_IFELSE([AC_LANG_PROGRAM([[ #include <unistd.h> ]],[[ fdatasync(4); ]])], [ac_cv_func_fdatasync=yes], [ac_cv_func_fdatasync=no]) -]) AS_IF([test "x${ac_cv_func_fdatasync}" = "xyes"], [AC_DEFINE([HAVE_FDATASYNC],[1],[If the system has a working fdatasync])])
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
On 12-11-2009 10:11:13 +0100, Stefan Manegold wrote:
On Thu, Nov 12, 2009 at 09:06:23AM +0000, Fabian wrote:
Update of /cvsroot/monetdb/MonetDB In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv25980
Modified Files: Tag: Nov2009 configure.ag Log Message: Yippy yay for messing with this at this stage of the development cycle... Revert my yesterday's commit here as it not only breaks compilation on OSX 10.6 (the original problem), but also Solaris 10. We need to facilitate people doing cross-compilation in some other way.
Might simply using AC_CHECK_FUNCS(fdatasync) be an option, here?
That's the whole problem, for some reason configure then thinks the function is available, which it is not on OSX 10.6.
I now try a version using AC_TRY_LINK, as I only used AC_TRY_COMPILE in yesterday's patch.
On Thu, Nov 12, 2009 at 10:13:22AM +0100, Fabian Groffen wrote:
On 12-11-2009 10:11:13 +0100, Stefan Manegold wrote:
On Thu, Nov 12, 2009 at 09:06:23AM +0000, Fabian wrote:
Update of /cvsroot/monetdb/MonetDB In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv25980
Modified Files: Tag: Nov2009 configure.ag Log Message: Yippy yay for messing with this at this stage of the development cycle... Revert my yesterday's commit here as it not only breaks compilation on OSX 10.6 (the original problem), but also Solaris 10. We need to facilitate people doing cross-compilation in some other way.
Might simply using AC_CHECK_FUNCS(fdatasync) be an option, here?
That's the whole problem, for some reason configure then thinks the function is available, which it is not on OSX 10.6.
The reason is that with compilation, only, a non-declared triggers only a warning with most compilers: from http://monetdb.cwi.nl/testing/projects/monetdb/Stable/MonetDB/.GNU.32.32.d.1... ======== configure:39146: checking for fdatasync configure:39177: gcc -c -O2 -Wall -Wextra -O6 -fomit-frame-pointer -finline-functions -falign-loops=4 -falign-jumps=4 -falign-functions=4 -fexpensive-optimizations -funroll-loops -frerun-cse-after-loop -frerun-loop-opt -ftree-vectorize -std=c99 conftest.c >&5 conftest.c: In function 'main': conftest.c:111: warning: implicit declaration of function 'fdatasync' configure:39183: $? = 0 configure:39199: result: yes ======== (and, provided I recall correctly, we cannot turn warnings into errors with/during configure, as then too many configure checks would fail ...)
I was hoping that AC_CHECK_FUNCS would do more than just compile, e.g., also (try to) link ...
I now try a version using AC_TRY_LINK, as I only used AC_TRY_COMPILE in yesterday's patch.
That might indeed be the best idea, then ...
Stefan
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
On 12-11-2009 10:33:16 +0100, Stefan Manegold wrote:
(and, provided I recall correctly, we cannot turn warnings into errors with/during configure, as then too many configure checks would fail ...)
I was hoping that AC_CHECK_FUNCS would do more than just compile, e.g., also (try to) link ...
we're not the only one having this problem, as far as google is concerned.
I now try a version using AC_TRY_LINK, as I only used AC_TRY_COMPILE in yesterday's patch.
That might indeed be the best idea, then ...
at least my most recent commit seems to work on linux, solaris 10 and opensolaris, I'll check if I can get our cripple mac to do something useful for a second, although we really need a 10.6 box to be able to test the fix.
I just updated to snow leopard and the problem still persists...
Do you want any information from my side?
On Nov 12, 2009, at 10:36, Fabian Groffen wrote:
On 12-11-2009 10:33:16 +0100, Stefan Manegold wrote:
(and, provided I recall correctly, we cannot turn warnings into errors with/during configure, as then too many configure checks would fail ...)
I was hoping that AC_CHECK_FUNCS would do more than just compile, e.g., also (try to) link ...
we're not the only one having this problem, as far as google is concerned.
I now try a version using AC_TRY_LINK, as I only used AC_TRY_COMPILE in yesterday's patch.
That might indeed be the best idea, then ...
at least my most recent commit seems to work on linux, solaris 10 and opensolaris, I'll check if I can get our cripple mac to do something useful for a second, although we really need a 10.6 box to be able to test the fix.
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
On 14-12-2009 20:35:16 +0100, Jan Rittinger wrote:
I just updated to snow leopard and the problem still persists...
Do you want any information from my side?
I want your configure output and your config.log file, please. (Off-list is fine)
participants (3)
-
Fabian Groffen -
Jan Rittinger -
Stefan Manegold