Updating for GCC 6

newer
Announcement: New release...

older
Cache functions ?

Sahasranaman M S

24 May 2016 24 May '16

9:35 a.m.

Hi all,

GCC 6.1 was relased late last month, and it was failing to build latest MonetDB, with the below 3 errors:

stream.c:2116:24: error: logical ‘or’ of equal expressions [-Werror=logical-op]

(errno == EAGAIN || errno == EWOULDBLOCK) && /* it was! */

stream.c:2142:24: error: logical ‘or’ of equal expressions [-Werror=logical-op]

(errno == EAGAIN || errno == EWOULDBLOCK)

mal_module.c: In function ‘getHelp’: mal_module.c:455:3: error: this ‘for’ clause does not guard... [-Werror=misleading-indentation] for(s= m->subscope[j]; s; s= s->peer) ^~~ mal_module.c:513:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘for’ m= m->sibling; ^

The first two appear to be because EAGAIN, EWOULDBLOCK have the same value on my machine (x86_64, Fedora 23 64bit). I don't know in what situation they would be different from each other, so I'm removing the check for EWOULDBLOCK and checking only for EAGAIN, as suggested by some on the Internet.

The third error is due to bad indentation. If we reduce indentation of mal_module.c:513 by two levels, that solves it.

It works for me with these changes, could someone confirm my solution to first two errors won't cause regressions, of suggest alternative solutions?

Thanks, Sahas

Attachments:

attachment.html (text/html — 3.9 KB)

Show replies by date

Sahasranaman M S

24 May 24 May

10:24 a.m.

I missed a few errors in my previous email. I'm attaching a diff file will all the changes needed to get it to compile.

Thanks, Sahas

Sjoerd Mullender

11:51 a.m.

Thanks. I applied fixes inspired by your patch (i.e. not identical to your patch).

On 24/05/16 12:24, Sahasranaman M S wrote:

...

I missed a few errors in my previous email. I'm attaching a diff file will all the changes needed to get it to compile.

Thanks, Sahas

developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list

-- Sjoerd Mullender

Sahasranaman M S

12:36 p.m.

Thanks Sjoerd, all errors have cleared, except for one last indentation issue. I've attached a patch.

Thanks, Sahas

On Tue, May 24, 2016 at 5:21 PM, Sjoerd Mullender sjoerd@monetdb.org wrote:

...

Thanks. I applied fixes inspired by your patch (i.e. not identical to your patch).

On 24/05/16 12:24, Sahasranaman M S wrote:

...
I missed a few errors in my previous email. I'm attaching a diff file will all the changes needed to get it to compile.

Thanks, Sahas

developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list

-- Sjoerd Mullender

developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list

Sjoerd Mullender

12:50 p.m.

It helps when you specify the version you're using ;-) . I've fixed the indent.

On 24/05/16 14:36, Sahasranaman M S wrote:

...

Thanks Sjoerd, all errors have cleared, except for one last indentation issue. I've attached a patch.

Thanks, Sahas

On Tue, May 24, 2016 at 5:21 PM, Sjoerd Mullender <sjoerd@monetdb.org mailto:sjoerd@monetdb.org> wrote:
Thanks.  I applied fixes inspired by your patch (i.e. not identical to
your patch).

On 24/05/16 12:24, Sahasranaman M S wrote:
> I missed a few errors in my previous email.  I'm attaching a diff file
> will all the changes needed to get it to compile.
>
> Thanks,
> Sahas
>
>
> _______________________________________________
> developers-list mailing list
> developers-list@monetdb.org <mailto:developers-list@monetdb.org>
> https://www.monetdb.org/mailman/listinfo/developers-list
>


--
Sjoerd Mullender


_______________________________________________
developers-list mailing list
developers-list@monetdb.org <mailto:developers-list@monetdb.org>
https://www.monetdb.org/mailman/listinfo/developers-list
developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list

-- Sjoerd Mullender

Sahasranaman M S

1 p.m.

Thanks, works now. Sorry about the version - I'm new to Mercurial, just realised I have to 'hg update' after 'hg pull' to get the latest version. :-)

On Tue, May 24, 2016 at 6:20 PM, Sjoerd Mullender sjoerd@monetdb.org wrote:

...

It helps when you specify the version you're using ;-) . I've fixed the indent.

On 24/05/16 14:36, Sahasranaman M S wrote:

...
Thanks Sjoerd, all errors have cleared, except for one last indentation issue. I've attached a patch.

Thanks, Sahas

On Tue, May 24, 2016 at 5:21 PM, Sjoerd Mullender <sjoerd@monetdb.org mailto:sjoerd@monetdb.org> wrote:
Thanks.  I applied fixes inspired by your patch (i.e. not identical
to

...
your patch).

On 24/05/16 12:24, Sahasranaman M S wrote:
> I missed a few errors in my previous email.  I'm attaching a diff
file

...
> will all the changes needed to get it to compile.
>
> Thanks,
> Sahas
>
>
> _______________________________________________
> developers-list mailing list
> developers-list@monetdb.org <mailto:developers-list@monetdb.org>
> https://www.monetdb.org/mailman/listinfo/developers-list
>


--
Sjoerd Mullender


_______________________________________________
developers-list mailing list
developers-list@monetdb.org <mailto:developers-list@monetdb.org>
https://www.monetdb.org/mailman/listinfo/developers-list
developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list
-- Sjoerd Mullender

developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list

Sjoerd Mullender

2:27 p.m.

On 24/05/16 15:00, Sahasranaman M S wrote:

...

Thanks, works now. Sorry about the version - I'm new to Mercurial, just realised I have to 'hg update' after 'hg pull' to get the latest version. :-)

Use 'hg pull -u'

...

On Tue, May 24, 2016 at 6:20 PM, Sjoerd Mullender <sjoerd@monetdb.org mailto:sjoerd@monetdb.org> wrote:

It helps when you specify the version you're using ;-) .
I've fixed the indent.

On 24/05/16 14:36, Sahasranaman M S wrote:
> Thanks Sjoerd,  all errors have cleared,  except for one last
> indentation issue.  I've attached a patch.
>
> Thanks,
> Sahas
>
> On Tue, May 24, 2016 at 5:21 PM, Sjoerd Mullender <sjoerd@monetdb.org <mailto:sjoerd@monetdb.org>
> <mailto:sjoerd@monetdb.org <mailto:sjoerd@monetdb.org>>> wrote:
>
>     Thanks.  I applied fixes inspired by your patch (i.e. not identical to
>     your patch).
>
>     On 24/05/16 12:24, Sahasranaman M S wrote:
>     > I missed a few errors in my previous email.  I'm attaching a diff file
>     > will all the changes needed to get it to compile.
>     >
>     > Thanks,
>     > Sahas
>     >
>     >
>     > _______________________________________________
>     > developers-list mailing list
>     > developers-list@monetdb.org
<mailto:developers-list@monetdb.org>
<mailto:developers-list@monetdb.org
<mailto:developers-list@monetdb.org>>
>     > https://www.monetdb.org/mailman/listinfo/developers-list
>     >
>
>
>     --
>     Sjoerd Mullender
>
>
>     _______________________________________________
>     developers-list mailing list
>     developers-list@monetdb.org
<mailto:developers-list@monetdb.org>
<mailto:developers-list@monetdb.org
<mailto:developers-list@monetdb.org>>
>     https://www.monetdb.org/mailman/listinfo/developers-list
>
>
>
>
> _______________________________________________
> developers-list mailing list
> developers-list@monetdb.org <mailto:developers-list@monetdb.org>
> https://www.monetdb.org/mailman/listinfo/developers-list
>


--
Sjoerd Mullender


_______________________________________________
developers-list mailing list
developers-list@monetdb.org <mailto:developers-list@monetdb.org>
https://www.monetdb.org/mailman/listinfo/developers-list

developers-list mailing list developers-list@monetdb.org https://www.monetdb.org/mailman/listinfo/developers-list

-- Sjoerd Mullender

2905

Age (days ago)

2905

Last active (days ago)

List overview

Download

6 comments

2 participants

tags (0)

participants (2)

Sahasranaman M S
Sjoerd Mullender