Re: [Monetdb-developers] MonetDB: default - Added missing stuff
Just to double check, since your log message does not appear to match your changes:
message: "*Added* missing stuff"
changes: removed references to "trace" optimizer
Where the changes indeed intended as done, "despite" the log message
Stefan
On Thu, Jul 26, 2012 at 10:39:15AM +0200, Martin Kersten wrote:
Changeset: 7ad5e675d7e4 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=7ad5e675d7e4 Modified Files: monetdb5/optimizer/opt_support.c monetdb5/optimizer/opt_wrapper.c Branch: default Log Message:
Added missing stuff
diffs (30 lines):
diff --git a/monetdb5/optimizer/opt_support.c b/monetdb5/optimizer/opt_support.c --- a/monetdb5/optimizer/opt_support.c +++ b/monetdb5/optimizer/opt_support.c @@ -181,7 +181,6 @@ struct OPTcatalog { {"selcrack", 0, 0, 0, DEBUG_OPT_SELCRACK}, {"sidcrack", 0, 0, 0, DEBUG_OPT_SIDCRACK}, {"strengthreduction", 0, 0, 0, DEBUG_OPT_STRENGTHREDUCTION}, -{"trace", 0, 0, 0, DEBUG_OPT_TRACE}, {"centipede", 0, 0, 0, DEBUG_OPT_CENTIPEDE}, { 0, 0, 0, 0, 0} }; diff --git a/monetdb5/optimizer/opt_wrapper.c b/monetdb5/optimizer/opt_wrapper.c --- a/monetdb5/optimizer/opt_wrapper.c +++ b/monetdb5/optimizer/opt_wrapper.c @@ -73,7 +73,6 @@ All Rights Reserved. #include "opt_reorder.h" #include "opt_statistics.h" #include "opt_strengthReduction.h" -#include "opt_trace.h"
struct{ str nme; @@ -113,7 +112,6 @@ struct{ {"remoteQueries", &OPTremoteQueriesImplementation}, {"reorder", &OPTreorderImplementation}, {"strengthReduction", &OPTstrengthReductionImplementation},
- {"trace", &OPTtraceImplementation}, {0,0}
}; opt_export str OPTwrapper(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr p); _______________________________________________ Checkin-list mailing list Checkin-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/checkin-list
I had forgotten to remove a few references in the first round due to interrupted session. On 7/26/12 10:48 AM, Stefan Manegold wrote:
Just to double check, since your log message does not appear to match your changes:
message: "*Added* missing stuff"
changes: removed references to "trace" optimizer
Where the changes indeed intended as done, "despite" the log message
Stefan
On Thu, Jul 26, 2012 at 10:39:15AM +0200, Martin Kersten wrote:
Changeset: 7ad5e675d7e4 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=7ad5e675d7e4 Modified Files: monetdb5/optimizer/opt_support.c monetdb5/optimizer/opt_wrapper.c Branch: default Log Message:
Added missing stuff
diffs (30 lines):
diff --git a/monetdb5/optimizer/opt_support.c b/monetdb5/optimizer/opt_support.c --- a/monetdb5/optimizer/opt_support.c +++ b/monetdb5/optimizer/opt_support.c @@ -181,7 +181,6 @@ struct OPTcatalog { {"selcrack", 0, 0, 0, DEBUG_OPT_SELCRACK}, {"sidcrack", 0, 0, 0, DEBUG_OPT_SIDCRACK}, {"strengthreduction", 0, 0, 0, DEBUG_OPT_STRENGTHREDUCTION}, -{"trace", 0, 0, 0, DEBUG_OPT_TRACE}, {"centipede", 0, 0, 0, DEBUG_OPT_CENTIPEDE}, { 0, 0, 0, 0, 0} }; diff --git a/monetdb5/optimizer/opt_wrapper.c b/monetdb5/optimizer/opt_wrapper.c --- a/monetdb5/optimizer/opt_wrapper.c +++ b/monetdb5/optimizer/opt_wrapper.c @@ -73,7 +73,6 @@ All Rights Reserved. #include "opt_reorder.h" #include "opt_statistics.h" #include "opt_strengthReduction.h" -#include "opt_trace.h"
struct{ str nme; @@ -113,7 +112,6 @@ struct{ {"remoteQueries", &OPTremoteQueriesImplementation}, {"reorder", &OPTreorderImplementation}, {"strengthReduction", &OPTstrengthReductionImplementation},
- {"trace", &OPTtraceImplementation}, {0,0} }; opt_export str OPTwrapper(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr p);
Checkin-list mailing list Checkin-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/checkin-list
I see.
Thanks for clarifying!
S.
----- Original Message -----
I had forgotten to remove a few references in the first round due to interrupted session. On 7/26/12 10:48 AM, Stefan Manegold wrote:
Just to double check, since your log message does not appear to match your changes:
message: "*Added* missing stuff"
changes: removed references to "trace" optimizer
Where the changes indeed intended as done, "despite" the log message
Stefan
On Thu, Jul 26, 2012 at 10:39:15AM +0200, Martin Kersten wrote:
Changeset: 7ad5e675d7e4 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=7ad5e675d7e4 Modified Files: monetdb5/optimizer/opt_support.c monetdb5/optimizer/opt_wrapper.c Branch: default Log Message:
Added missing stuff
diffs (30 lines):
diff --git a/monetdb5/optimizer/opt_support.c b/monetdb5/optimizer/opt_support.c --- a/monetdb5/optimizer/opt_support.c +++ b/monetdb5/optimizer/opt_support.c @@ -181,7 +181,6 @@ struct OPTcatalog { {"selcrack", 0, 0, 0, DEBUG_OPT_SELCRACK}, {"sidcrack", 0, 0, 0, DEBUG_OPT_SIDCRACK}, {"strengthreduction", 0, 0, 0, DEBUG_OPT_STRENGTHREDUCTION}, -{"trace", 0, 0, 0, DEBUG_OPT_TRACE}, {"centipede", 0, 0, 0, DEBUG_OPT_CENTIPEDE}, { 0, 0, 0, 0, 0} }; diff --git a/monetdb5/optimizer/opt_wrapper.c b/monetdb5/optimizer/opt_wrapper.c --- a/monetdb5/optimizer/opt_wrapper.c +++ b/monetdb5/optimizer/opt_wrapper.c @@ -73,7 +73,6 @@ All Rights Reserved. #include "opt_reorder.h" #include "opt_statistics.h" #include "opt_strengthReduction.h" -#include "opt_trace.h"
struct{ str nme; @@ -113,7 +112,6 @@ struct{ {"remoteQueries", &OPTremoteQueriesImplementation}, {"reorder", &OPTreorderImplementation}, {"strengthReduction", &OPTstrengthReductionImplementation},
- {"trace", &OPTtraceImplementation}, {0,0} }; opt_export str OPTwrapper(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr p);
Checkin-list mailing list Checkin-list@monetdb.org http://mail.monetdb.org/mailman/listinfo/checkin-list
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
participants (2)
-
Martin Kersten -
Stefan Manegold