Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/compiler/debug logdebug.c, , 1.131, 1.132
Hi Tom,
this looks like a bug fix to me.
Shouldn't that checkin then have gone to the new Aug2009 release branch?
Otherwise, this fix will surely not be in the next releases (Aug2009, Aug2009-SP1, Aug2009-SP2) ...
Let me know, in case you need advice or help with back-porting this one to the Aug2009 release branch (using CVS commands, only, to prevent conflicts), and with checkin in future bug fixes to the release branch.
Thanks!
Stefan
On Tue, Aug 04, 2009 at 08:50:10AM +0000, Tom Schreiber wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/debug In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv12470/compiler/debug
Modified Files: logdebug.c Log Message: -- Fixed a small bug in the dot output for algebra plans: planheader-port-id's and their references were unaligned (causing warnings from the dot executable).
U logdebug.c Index: logdebug.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/debug/logdebug.c,v retrieving revision 1.131 retrieving revision 1.132 diff -u -d -r1.131 -r1.132 --- logdebug.c 31 Jul 2009 13:06:21 -0000 1.131 +++ logdebug.c 4 Aug 2009 08:50:07 -0000 1.132 @@ -2621,7 +2621,7 @@ for (unsigned int j = 0; j < clsize (root->sem.ser_rel.items); j++) fprintf (f, "%s <item%u> %s ", (j ? "|" : ""),
j,
j + 1, PFcol_str (clat (root->sem.ser_rel.items, j))); fprintf (f, "}}}\"];\n" "subgraph clusterPlan%i {\n", id);
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
Hi Stefan,
It's a fix to a really uncritical bug. Planheaders and planheader-port- id's are only used in dot-files for algebra plan bundles which are at the moment only produced by our group's Ferry stuff. And despite the unaligned port-id's inside the dot-files (which causes the dot executable to produce warning messages), the resulting pdf-files look perfectly ok. Should I still backport this one?
Greetings from Tübingen, Tom
On Aug 4, 2009, at 14:00, Stefan Manegold wrote:
Hi Tom,
this looks like a bug fix to me.
Shouldn't that checkin then have gone to the new Aug2009 release branch?
Otherwise, this fix will surely not be in the next releases (Aug2009, Aug2009-SP1, Aug2009-SP2) ...
Let me know, in case you need advice or help with back-porting this one to the Aug2009 release branch (using CVS commands, only, to prevent conflicts), and with checkin in future bug fixes to the release branch.
Thanks!
Stefan
On Tue, Aug 04, 2009 at 08:50:10AM +0000, Tom Schreiber wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/debug In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv12470/ compiler/debug
Modified Files: logdebug.c Log Message: -- Fixed a small bug in the dot output for algebra plans: planheader-port-id's and their references were unaligned (causing warnings from the dot executable).
U logdebug.c Index: logdebug.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/debug/logdebug.c,v retrieving revision 1.131 retrieving revision 1.132 diff -u -d -r1.131 -r1.132 --- logdebug.c 31 Jul 2009 13:06:21 -0000 1.131 +++ logdebug.c 4 Aug 2009 08:50:07 -0000 1.132 @@ -2621,7 +2621,7 @@ for (unsigned int j = 0; j < clsize (root-
sem.ser_rel.items); j++)
fprintf (f, "%s <item%u> %s ", (j ? "|" : ""),
j,
j + 1, PFcol_str (clat (root->sem.ser_rel.items, j))); fprintf (f, "}}}\"];\n" "subgraph clusterPlan%i {\n", id);
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
On Tue, Aug 04, 2009 at 02:16:21PM +0200, Tom wrote:
Hi Stefan,
It's a fix to a really uncritical bug. Planheaders and planheader-port- id's are only used in dot-files for algebra plan bundles which are at the moment only produced by our group's Ferry stuff. And despite the unaligned port-id's inside the dot-files (which causes the dot executable to produce warning messages), the resulting pdf-files look perfectly ok.
Thanks!
Should I still backport this one?
Yes. ;-)
Stefan
Greetings from Tübingen, Tom
On Aug 4, 2009, at 14:00, Stefan Manegold wrote:
Hi Tom,
this looks like a bug fix to me.
Shouldn't that checkin then have gone to the new Aug2009 release branch?
Otherwise, this fix will surely not be in the next releases (Aug2009, Aug2009-SP1, Aug2009-SP2) ...
Let me know, in case you need advice or help with back-porting this one to the Aug2009 release branch (using CVS commands, only, to prevent conflicts), and with checkin in future bug fixes to the release branch.
Thanks!
Stefan
On Tue, Aug 04, 2009 at 08:50:10AM +0000, Tom Schreiber wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/debug In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv12470/ compiler/debug
Modified Files: logdebug.c Log Message: -- Fixed a small bug in the dot output for algebra plans: planheader-port-id's and their references were unaligned (causing warnings from the dot executable).
U logdebug.c Index: logdebug.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/debug/logdebug.c,v retrieving revision 1.131 retrieving revision 1.132 diff -u -d -r1.131 -r1.132 --- logdebug.c 31 Jul 2009 13:06:21 -0000 1.131 +++ logdebug.c 4 Aug 2009 08:50:07 -0000 1.132 @@ -2621,7 +2621,7 @@ for (unsigned int j = 0; j < clsize (root-
sem.ser_rel.items); j++)
fprintf (f, "%s <item%u> %s ", (j ? "|" : ""),
j,
j + 1, PFcol_str (clat (root->sem.ser_rel.items, j))); fprintf (f, "}}}\"];\n" "subgraph clusterPlan%i {\n", id);
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
Hi Stefan,
ok, then I need advice and help with back-porting this one to the Aug2009 release branch (using CVS commands, only, to prevent conflicts), and with checkin in future bug fixes to the release branch.
Tom
On Aug 4, 2009, at 14:46, Stefan Manegold wrote:
On Tue, Aug 04, 2009 at 02:16:21PM +0200, Tom wrote:
Hi Stefan,
It's a fix to a really uncritical bug. Planheaders and planheader- port- id's are only used in dot-files for algebra plan bundles which are at the moment only produced by our group's Ferry stuff. And despite the unaligned port-id's inside the dot-files (which causes the dot executable to produce warning messages), the resulting pdf-files look perfectly ok.
Thanks!
Should I still backport this one?
Yes. ;-)
Stefan
Greetings from Tübingen, Tom
On Aug 4, 2009, at 14:00, Stefan Manegold wrote:
Hi Tom,
this looks like a bug fix to me.
Shouldn't that checkin then have gone to the new Aug2009 release branch?
Otherwise, this fix will surely not be in the next releases (Aug2009, Aug2009-SP1, Aug2009-SP2) ...
Let me know, in case you need advice or help with back-porting this one to the Aug2009 release branch (using CVS commands, only, to prevent conflicts), and with checkin in future bug fixes to the release branch.
Thanks!
Stefan
On Tue, Aug 04, 2009 at 08:50:10AM +0000, Tom Schreiber wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/debug In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv12470/ compiler/debug
Modified Files: logdebug.c Log Message: -- Fixed a small bug in the dot output for algebra plans: planheader-port-id's and their references were unaligned (causing warnings from the dot executable).
U logdebug.c Index: logdebug.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/debug/logdebug.c,v retrieving revision 1.131 retrieving revision 1.132 diff -u -d -r1.131 -r1.132 --- logdebug.c 31 Jul 2009 13:06:21 -0000 1.131 +++ logdebug.c 4 Aug 2009 08:50:07 -0000 1.132 @@ -2621,7 +2621,7 @@ for (unsigned int j = 0; j < clsize (root-
sem.ser_rel.items); j++)
fprintf (f, "%s <item%u> %s ", (j ? "|" : ""),
j,
j + 1, PFcol_str (clat (root->sem.ser_rel.items, j))); fprintf (f, "}}}\"];\n" "subgraph clusterPlan%i {\n", id);
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
On Tue, Aug 04, 2009 at 02:53:29PM +0200, Tom wrote:
Hi Stefan,
ok, then I need advice and help with back-porting this one to the Aug2009 release branch (using CVS commands, only, to prevent conflicts), and with checkin in future bug fixes to the release branch.
see pages 8 - 16 (in particular page 14) of http://homepages.cwi.nl/~manegold/Presentations/MonetDBdevTTT.pdf
feel free ask again, in case there still questions! ;-)
Stefam
Tom
On Aug 4, 2009, at 14:46, Stefan Manegold wrote:
On Tue, Aug 04, 2009 at 02:16:21PM +0200, Tom wrote:
Hi Stefan,
It's a fix to a really uncritical bug. Planheaders and planheader- port- id's are only used in dot-files for algebra plan bundles which are at the moment only produced by our group's Ferry stuff. And despite the unaligned port-id's inside the dot-files (which causes the dot executable to produce warning messages), the resulting pdf-files look perfectly ok.
Thanks!
Should I still backport this one?
Yes. ;-)
Stefan
Greetings from Tübingen, Tom
On Aug 4, 2009, at 14:00, Stefan Manegold wrote:
Hi Tom,
this looks like a bug fix to me.
Shouldn't that checkin then have gone to the new Aug2009 release branch?
Otherwise, this fix will surely not be in the next releases (Aug2009, Aug2009-SP1, Aug2009-SP2) ...
Let me know, in case you need advice or help with back-porting this one to the Aug2009 release branch (using CVS commands, only, to prevent conflicts), and with checkin in future bug fixes to the release branch.
Thanks!
Stefan
On Tue, Aug 04, 2009 at 08:50:10AM +0000, Tom Schreiber wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/debug In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv12470/ compiler/debug
Modified Files: logdebug.c Log Message: -- Fixed a small bug in the dot output for algebra plans: planheader-port-id's and their references were unaligned (causing warnings from the dot executable).
U logdebug.c Index: logdebug.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/debug/logdebug.c,v retrieving revision 1.131 retrieving revision 1.132 diff -u -d -r1.131 -r1.132 --- logdebug.c 31 Jul 2009 13:06:21 -0000 1.131 +++ logdebug.c 4 Aug 2009 08:50:07 -0000 1.132 @@ -2621,7 +2621,7 @@ for (unsigned int j = 0; j < clsize (root-
sem.ser_rel.items); j++)
fprintf (f, "%s <item%u> %s ", (j ? "|" : ""),
j,
j + 1, PFcol_str (clat (root->sem.ser_rel.items, j))); fprintf (f, "}}}\"];\n" "subgraph clusterPlan%i {\n", id);
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
participants (2)
-
Stefan Manegold -
Tom