Re: [Monetdb-developers] [Monetdb-checkins] MonetDB/NT monetdb_winconfig.h, , 1.2, 1.3
On Wed, Oct 10, 2007 at 09:05:45AM +0000, Romulo Goncalves wrote:
Update of /cvsroot/monetdb/MonetDB/NT In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv14659
Modified Files: monetdb_winconfig.h Log Message: Move the definition of ssize_t as int into the win32 else clause Please check if it is correct like this. The compilation works, but it gives warnnings about probable lost of data witht the convertion from ssize_t to BUN.
Shouldn't this also be done on the stable? The move of the line is fine.
BUN in cvs head is still a 'size_t' (same as oid), ie ssize_t (signed) indeed may lose info.
Niels
Index: monetdb_winconfig.h
RCS file: /cvsroot/monetdb/MonetDB/NT/monetdb_winconfig.h,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- monetdb_winconfig.h 3 Oct 2007 13:59:59 -0000 1.2 +++ monetdb_winconfig.h 10 Oct 2007 09:05:43 -0000 1.3 @@ -668,13 +668,14 @@
/* The size of a `void *', as computed by sizeof. */ #define SIZEOF_VOID_P 4 -#endif
/* The size of a `ssize_t', as computed by sizeof. */ #define SIZEOF_SSIZE_T SIZEOF_SIZE_T typedef int ssize_t; #define HAVE_SSIZE_T 1
+#endif /* The size of a `__int64', as computed by sizeof. */ #define SIZEOF___INT64 8
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
Niels Nes wrote:
On Wed, Oct 10, 2007 at 09:05:45AM +0000, Romulo Goncalves wrote:
Update of /cvsroot/monetdb/MonetDB/NT In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv14659
Modified Files: monetdb_winconfig.h Log Message: Move the definition of ssize_t as int into the win32 else clause Please check if it is correct like this. The compilation works, but it gives warnnings about probable lost of data witht the convertion from ssize_t to BUN.
Shouldn't this also be done on the stable?
Well, on windows 64 I am using the current branch and not the stable. But if the problem also exist in the stable, yes I did the commit on the wrong one. I will checkout the stable, do there the commit and revert this one.
Sorry...
Regards, Romulo
The move of the line is fine.
BUN in cvs head is still a 'size_t' (same as oid), ie ssize_t (signed) indeed may lose info.
Niels
Index: monetdb_winconfig.h
RCS file: /cvsroot/monetdb/MonetDB/NT/monetdb_winconfig.h,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- monetdb_winconfig.h 3 Oct 2007 13:59:59 -0000 1.2 +++ monetdb_winconfig.h 10 Oct 2007 09:05:43 -0000 1.3 @@ -668,13 +668,14 @@
/* The size of a `void *', as computed by sizeof. */ #define SIZEOF_VOID_P 4 -#endif
/* The size of a `ssize_t', as computed by sizeof. */ #define SIZEOF_SSIZE_T SIZEOF_SIZE_T typedef int ssize_t; #define HAVE_SSIZE_T 1
+#endif /* The size of a `__int64', as computed by sizeof. */ #define SIZEOF___INT64 8
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
Romulo Goncalves wrote:
Niels Nes wrote:
On Wed, Oct 10, 2007 at 09:05:45AM +0000, Romulo Goncalves wrote:
Update of /cvsroot/monetdb/MonetDB/NT In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv14659
Modified Files: monetdb_winconfig.h Log Message: Move the definition of ssize_t as int into the win32 else clause Please check if it is correct like this. The compilation works, but it gives warnnings about probable lost of data witht the convertion from ssize_t to BUN.
Shouldn't this also be done on the stable?
Well, on windows 64 I am using the current branch and not the stable. But if the problem also exist in the stable, yes I did the commit on the wrong one. I will checkout the stable, do there the commit and revert this one.
Don't revert, but do the change in the identical way (e.g. using cvs up with two -j options).
Sorry...
Regards, Romulo
The move of the line is fine.
BUN in cvs head is still a 'size_t' (same as oid), ie ssize_t (signed) indeed may lose info.
Niels
Index: monetdb_winconfig.h
RCS file: /cvsroot/monetdb/MonetDB/NT/monetdb_winconfig.h,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- monetdb_winconfig.h 3 Oct 2007 13:59:59 -0000 1.2 +++ monetdb_winconfig.h 10 Oct 2007 09:05:43 -0000 1.3 @@ -668,13 +668,14 @@
/* The size of a `void *', as computed by sizeof. */ #define SIZEOF_VOID_P 4 -#endif
/* The size of a `ssize_t', as computed by sizeof. */ #define SIZEOF_SSIZE_T SIZEOF_SIZE_T typedef int ssize_t; #define HAVE_SSIZE_T 1
+#endif /* The size of a `__int64', as computed by sizeof. */ #define SIZEOF___INT64 8
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
participants (3)
-
Niels Nes -
Romulo Goncalves -
Sjoerd Mullender