Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/mal mal_instruction.mx, , 1.372, 1.373
On Wed, Nov 26, 2008 at 08:21:17PM +0000, Martin Kersten wrote:
Update of /cvsroot/monetdb/MonetDB5/src/mal In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv13401
Modified Files: mal_instruction.mx Log Message: An experiment for the nightly tests to address e.g. Darwin color test. Should be handled correctly by GDK.
U mal_instruction.mx Index: mal_instruction.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/mal/mal_instruction.mx,v retrieving revision 1.372 retrieving revision 1.373 diff -u -d -r1.372 -r1.373 --- mal_instruction.mx 23 Nov 2008 15:48:14 -0000 1.372 +++ mal_instruction.mx 26 Nov 2008 20:21:14 -0000 1.373 @@ -1,4 +1,4 @@ -@' The contents of this file are subject to the MonetDB Public License +' The contents of this file are subject to the MonetDB Public License @' Version 1.1 (the "License"); you may not use this file except in @' compliance with the License. You may obtain a copy of the License at @' http://monetdb.cwi.nl/Legal/MonetDBLicense-1.1.html @@ -1715,7 +1715,6 @@ if( vr->vtype == type) return 0; if( vr->vtype == TYPE_str){ -#ifdef STRUCT_ALIGNED int ll = 0; ptr d = NULL;
@@ -1734,6 +1733,8 @@ VALset(vr, type, d); if (ATOMextern(type) == 0) GDKfree(d); +#ifdef STRUCT_ALIGNED
- /* experiment against alternative 32 bit platforms */
The problems does not seem to be 32-bit specific, but possibly big-endian related; it occurs on both 32- & 64-bit big-endian platforms such as PowerPC http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... and SPARC http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G...
similar problems occur with other tests on the same set of platforms: http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... Stefan
#else showException(SYNTAX, "convertConstant", "missing implementation"); #endif
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
Yes, that was known. The little/big endian code is not needed here is the hypothesis. Any such difference should be handled in the GDK layer.
Stefan Manegold wrote:
On Wed, Nov 26, 2008 at 08:21:17PM +0000, Martin Kersten wrote:
Update of /cvsroot/monetdb/MonetDB5/src/mal In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv13401
Modified Files: mal_instruction.mx Log Message: An experiment for the nightly tests to address e.g. Darwin color test. Should be handled correctly by GDK.
U mal_instruction.mx Index: mal_instruction.mx =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/mal/mal_instruction.mx,v retrieving revision 1.372 retrieving revision 1.373 diff -u -d -r1.372 -r1.373 --- mal_instruction.mx 23 Nov 2008 15:48:14 -0000 1.372 +++ mal_instruction.mx 26 Nov 2008 20:21:14 -0000 1.373 @@ -1,4 +1,4 @@ -@' The contents of this file are subject to the MonetDB Public License +' The contents of this file are subject to the MonetDB Public License @' Version 1.1 (the "License"); you may not use this file except in @' compliance with the License. You may obtain a copy of the License at @' http://monetdb.cwi.nl/Legal/MonetDBLicense-1.1.html @@ -1715,7 +1715,6 @@ if( vr->vtype == type) return 0; if( vr->vtype == TYPE_str){ -#ifdef STRUCT_ALIGNED int ll = 0; ptr d = NULL;
@@ -1734,6 +1733,8 @@ VALset(vr, type, d); if (ATOMextern(type) == 0) GDKfree(d); +#ifdef STRUCT_ALIGNED
- /* experiment against alternative 32 bit platforms */
The problems does not seem to be 32-bit specific, but possibly big-endian related; it occurs on both 32- & 64-bit big-endian platforms such as PowerPC http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... and SPARC http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G...
similar problems occur with other tests on the same set of platforms: http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/G... Stefan
#else showException(SYNTAX, "convertConstant", "missing implementation"); #endif
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
participants (2)
-
Martin Kersten -
Stefan Manegold