Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/modules/mal recycle.mx, , 1.9, 1.10
On Mon, Mar 10, 2008 at 11:21:59AM +0000, Romulo Goncalves wrote:
Update of /cvsroot/monetdb/MonetDB5/src/modules/mal In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv24521
Modified Files: recycle.mx Log Message: Check in the MALblk exist to avoid a mserver crash when we to recycle.dump() before any query execution
why do you check the loop-invariant condition with every iteration of the loop?
Stefan
Index: recycle.mx
RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/recycle.mx,v retrieving revision 1.9 retrieving revision 1.10 diff -u -d -r1.9 -r1.10 --- recycle.mx 9 Mar 2008 15:47:30 -0000 1.9 +++ recycle.mx 10 Mar 2008 11:21:47 -0000 1.10 @@ -147,7 +147,7 @@ stream_printf(GDKout,"Recycler catalog \n");
/* and dump the statistics */
- for(i=0; i< recycleBlk->stop; i++){
- for(i=0; recycleBlk && i< recycleBlk->stop; i++){ stream_printf(GDKout,"#%4d count=%3d ticks=%4d %s\n", i, recycleBlk->profiler[i].counter, recycleBlk->profiler[i].ticks,
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
Stefan Manegold wrote:
On Mon, Mar 10, 2008 at 11:21:59AM +0000, Romulo Goncalves wrote:
Update of /cvsroot/monetdb/MonetDB5/src/modules/mal In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv24521
Modified Files: recycle.mx Log Message: Check in the MALblk exist to avoid a mserver crash when we to recycle.dump() before any query execution
why do you check the loop-invariant condition with every iteration of the loop?
It was just a simple and lazy way to correct a bug... Maybe an if clause before the loop would be better...
Sorry and thanks... Romulo
Stefan
Index: recycle.mx
RCS file: /cvsroot/monetdb/MonetDB5/src/modules/mal/recycle.mx,v retrieving revision 1.9 retrieving revision 1.10 diff -u -d -r1.9 -r1.10 --- recycle.mx 9 Mar 2008 15:47:30 -0000 1.9 +++ recycle.mx 10 Mar 2008 11:21:47 -0000 1.10 @@ -147,7 +147,7 @@ stream_printf(GDKout,"Recycler catalog \n");
/* and dump the statistics */
- for(i=0; i< recycleBlk->stop; i++){
- for(i=0; recycleBlk && i< recycleBlk->stop; i++){ stream_printf(GDKout,"#%4d count=%3d ticks=%4d %s\n", i, recycleBlk->profiler[i].counter, recycleBlk->profiler[i].ticks,
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
participants (2)
-
Romulo Goncalves -
Stefan Manegold