Re: [Monetdb-developers] [Monetdb-pf-checkins] pathfinder/compiler/mil milprint.c, , 1.93, 1.94
Jan F (and Jan R),
or should my fix (below) rather have looked like this:
Index: pathfinder/compiler/mil/milprint.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/mil/milprint.c,v retrieving revision 1.93 diff -u -r1.93 milprint.c --- pathfinder/compiler/mil/milprint.c 10 Mar 2009 12:20:44 -0000 1.93 +++ pathfinder/compiler/mil/milprint.c 13 Mar 2009 08:39:16 -0000 @@ -429,7 +429,7 @@ , [m_egsum] = "{sum}" , [m_prod] = "prod" , [m_gprod] = "{prod}" - , [m_gprod] = "{prod}" + , [m_egprod] = "{prod}" , [m_bat] = "bat" , [m_catch] = "CATCH" , [m_error] = "ERROR"
?
Thanks!
Stefan
On Fri, Mar 13, 2009 at 08:37:07AM +0000, Stefan Manegold wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/mil In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv12904/pathfinder/compiler/mil
Modified Files: milprint.c Log Message:
fixing compilation error
.../pathfinder/compiler/mil/milprint.c:433: error: initialized field overwritten .../pathfinder/compiler/mil/milprint.c:433: error: (near initialization for ‘ID[111]’)
there is no need to initialize the same field twice with the same value
U milprint.c Index: milprint.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/mil/milprint.c,v retrieving revision 1.93 retrieving revision 1.94 diff -u -d -r1.93 -r1.94 --- milprint.c 10 Mar 2009 12:20:44 -0000 1.93 +++ milprint.c 13 Mar 2009 08:37:05 -0000 1.94 @@ -429,7 +429,6 @@ , [m_egsum] = "{sum}" , [m_prod] = "prod" , [m_gprod] = "{prod}"
- , [m_gprod] = "{prod}" , [m_bat] = "bat" , [m_catch] = "CATCH" , [m_error] = "ERROR"
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
On Fri, Mar 13, 2009 at 09:44:23AM +0100, Stefan Manegold wrote:
Jan F (and Jan R),
or should my fix (below) rather have looked like this:
Index: pathfinder/compiler/mil/milprint.c
RCS file: /cvsroot/monetdb/pathfinder/compiler/mil/milprint.c,v retrieving revision 1.93 diff -u -r1.93 milprint.c --- pathfinder/compiler/mil/milprint.c 10 Mar 2009 12:20:44 -0000 1.93 +++ pathfinder/compiler/mil/milprint.c 13 Mar 2009 08:39:16 -0000 @@ -429,7 +429,7 @@ , [m_egsum] = "{sum}" , [m_prod] = "prod" , [m_gprod] = "{prod}"
- , [m_gprod] = "{prod}"
- , [m_egprod] = "{prod}" , [m_bat] = "bat" , [m_catch] = "CATCH" , [m_error] = "ERROR"
?
well, without other changes, this would result in
.../pathfinder/compiler/mil/milprint.c:432: error: ‘m_egprod’ undeclared here (not in a function) .../pathfinder/compiler/mil/milprint.c:432: error: array index in initializer not of integer type .../pathfinder/compiler/mil/milprint.c:432: error: (near initialization for ‘ID’)
...
Stefan
Thanks!
Stefan
On Fri, Mar 13, 2009 at 08:37:07AM +0000, Stefan Manegold wrote:
Update of /cvsroot/monetdb/pathfinder/compiler/mil In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv12904/pathfinder/compiler/mil
Modified Files: milprint.c Log Message:
fixing compilation error
.../pathfinder/compiler/mil/milprint.c:433: error: initialized field overwritten .../pathfinder/compiler/mil/milprint.c:433: error: (near initialization for ‘ID[111]’)
there is no need to initialize the same field twice with the same value
U milprint.c Index: milprint.c =================================================================== RCS file: /cvsroot/monetdb/pathfinder/compiler/mil/milprint.c,v retrieving revision 1.93 retrieving revision 1.94 diff -u -d -r1.93 -r1.94 --- milprint.c 10 Mar 2009 12:20:44 -0000 1.93 +++ milprint.c 13 Mar 2009 08:37:05 -0000 1.94 @@ -429,7 +429,6 @@ , [m_egsum] = "{sum}" , [m_prod] = "prod" , [m_gprod] = "{prod}"
- , [m_gprod] = "{prod}" , [m_bat] = "bat" , [m_catch] = "CATCH" , [m_error] = "ERROR"
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Monetdb-pf-checkins mailing list Monetdb-pf-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins
-- | Dr. Stefan Manegold | mailto:Stefan.Manegold@cwi.nl | | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ | | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 | | The Netherlands | Fax : +31 (20) 592-4312 |
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Monetdb-developers mailing list Monetdb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-developers
participants (1)
-
Stefan Manegold