Bug 2853

Summary: Give proper error message when starting database that needs upgrade with --readonly
Product: SQL Reporter: Sjoerd Mullender <sjoerd>
Component: allAssignee: SQL devs <bugs-sql>
Status: NEW ---    
Severity: enhancement CC: mk, niels, renalkoclok, y.zhang
Priority: Normal Keywords: NONEEDTOTEST
Version: -- development   
Hardware: All   
OS: All   
Attachments: KONTOL

Description Sjoerd Mullender cwiconfidential 2011-08-09 14:27:17 CEST
mserver5 says:
mserver5: sql/storage/bat/bat_storage.c:815: dup_delta: Assertion `bat->ibid' failed.
Aborted

This is a blocker for a release.
Comment 1 Martin Kersten cwiconfidential 2011-08-13 10:26:08 CEST
The latest patch does not guarantee smooth transition without rebuilding Apr2011 sf100 instance.

# MonetDB/GIS module loaded
# MonetDB/SQL module loaded
!mvc_init: unable to create system tables
!SQLException:SQLinit:Catalogue initialization failed
!ERROR: Incompatible database version 051100, this server supports version 051101
!ERROR: Please move away /export/scratch0/mk/dbfarm/sf100/sql_logs/sql/ and its corresponding dbfarm.
# MonetDB/SQL module loaded
!mvc_init: unable to create system tables
!MALException:setScenario:Scenario not initialized 'sql'
!ERROR: Incompatible database version 051100, this server supports version 051101
!ERROR: Please move away /export/scratch0/mk/dbfarm/sf100/sql_logs/sql/ and its corresponding dbfarm.
Comment 2 Martin Kersten cwiconfidential 2011-08-13 10:43:21 CEST
The last message was a result of a read-only database.
Please check for this and announce to remove --readonly it before upgrade.

Upgrade of april database worked, but toke quite some time
Comment 3 Niels Nes cwiconfidential 2011-08-13 16:41:54 CEST
For readonly (and other restricted catalogs) we don't have upgrade functions. So its probably best to make the error message in gdk_logger.c include this information (ie cannot upgrade because of missing upgrade functions)
Comment 4 Sjoerd Mullender cwiconfidential 2011-08-22 19:54:32 CEST
Perhaps check_version in gdk_logger should call logger_fatal() instead of GDKerror().  Then it would exit there and then.  That will stop the cascade of error messages that we get now.  The only thing is, the logger doesn't (and cannot) know that the database was started with --readonly.
In any case, this is really a different bug.  The bug as it was originally has been fixed.
Comment 5 Niels Nes cwiconfidential 2011-10-14 12:55:52 CEST
The leftover part of this bug, is more a feature request
Comment 6 Sjoerd Mullender cwiconfidential 2012-08-24 14:55:52 CEST
Jul2012-SP1 has been released.
Comment 7 Ying Zhang cwiconfidential 2012-11-27 15:33:30 CET
Not possible to add test for this.
Comment 9 Sjoerd Mullender cwiconfidential 2020-06-03 09:21:16 CEST
The content of attachment 680 [details] has been deleted for the following reason:

spam