Stefan Manegold wrote:

On Tue, Aug 05, 2008 at 06:22:32AM +0000, Martin Kersten wrote:

...

Update of /cvsroot/monetdb/MonetDB5/src/mal/Tests In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv9480

Modified Files: tst052.mal tst052.stable.out Log Message: simplify test.

Martin,

wouldn't it have been better to keep the check whether type wrd is handled correctly on both 32-bit and 64-bit systems and approve the (correct!) 32-bit specific output instead of simply removing this check?

Stefan

...

U tst052.mal Index: tst052.mal =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/mal/Tests/tst052.mal,v retrieving revision 1.1 retrieving revision 1.2 diff -u -d -r1.1 -r1.2 --- tst052.mal 4 Aug 2008 06:57:09 -0000 1.1 +++ tst052.mal 5 Aug 2008 06:22:30 -0000 1.2 @@ -7,6 +7,5 @@ bat.insert(b,7,127:wrd); bat.insert(b,15,32768:wrd); bat.insert(b,31,2147483647:wrd); -bat.insert(b,63,9223372036854775807:wrd);

io.print(b);

U tst052.stable.out Index: tst052.stable.out =================================================================== RCS file: /cvsroot/monetdb/MonetDB5/src/mal/Tests/tst052.stable.out,v retrieving revision 1.1 retrieving revision 1.2 diff -u -d -r1.1 -r1.2 --- tst052.stable.out 4 Aug 2008 06:57:09 -0000 1.1 +++ tst052.stable.out 5 Aug 2008 06:22:30 -0000 1.2 @@ -32,10 +32,9 @@ bat.insert(b,7,127:wrd); # 5 _9:void := BKCinsert_bun(b:bat[:int,:wrd], _10:int, _11:wrd) bat.insert(b,15,32768:wrd); # 6 _12:void := BKCinsert_bun(b:bat[:int,:wrd], _13:int, _14:wrd) bat.insert(b,31,2147483647:wrd); # 7 _15:void := BKCinsert_bun(b:bat[:int,:wrd], _16:int, _17:wrd)

• bat.insert(b,63,9223372036854775807:wrd);# 8 _18:void := BKCinsert_bun(b:bat[:int,:wrd], _19:int, _20:wrd)
• io.print(b); # 9 _21:void := IOprint_val(b:bat[:int,:wrd])

-end main; # 10 -#---------------------------------#

• io.print(b); # 8 _18:void := IOprint_val(b:bat[:int,:wrd])

+end main; # 9 +#-------------------------# # h t # name # int wrd # type #---------------------------------# @@ -43,7 +42,6 @@ [ 7, 127 ] [ 15, 32768 ] [ 31, 2147483647 ] -[ 63, 9223372036854775807 ]

# 08:54:36 > # 08:54:36 > Done.

---

This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Monetdb-checkins mailing list Monetdb-checkins@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

could have been done, but this part is done at so many places already, i thought simplify basic resolution check was sufficient.