November 2008 - developers-list

Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/optimizer opt_history.mx, , 1.1, 1.2
by Romulo Goncalves 03 Nov '08

03 Nov '08

Martin Kersten wrote: > Update of /cvsroot/monetdb/MonetDB5/src/optimizer > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv32362 > > Modified Files: > opt_history.mx > Log Message: > Added the missing information. > > > U opt_history.mx > Index: opt_history.mx > =================================================================== > RCS file: /cvsroot/monetdb/MonetDB5/src/optimizer/opt_history.mx,v > retrieving revision 1.1 > retrieving revision 1.2 > diff -u -d -r1.1 -r1.2 > --- opt_history.mx 3 Nov 2008 06:35:34 -0000 1.1 > +++ opt_history.mx 3 Nov 2008 12:36:44 -0000 1.2 > @@ -32,7 +32,7 @@ > time you use the history without initialization. > The keepcall can be used to check for initialization of the cache. > @mal > -module user; > +module sql; > function keepquery{unsafe}(qid:int,qry:str,parse:lng,optimize:lng):void; > raise SQLexception:= "SQL history script should be run first"; > end keepquery; > @@ -44,6 +44,10 @@ > function queryId{unsafe}(qid:int):void; > end queryId; > > +pattern forgetPrevious():void > +address OPTforgetPrevious > +comment "invalidate the previous instruction from future execution"; > + > pattern optimizer.history():str > address OPThistory; > pattern optimizer.history(mod:str, fcn:str):str > @@ -61,6 +65,7 @@ > #include "mal_instruction.h" > #include "mal_function.h" > > +opt_export str OPTforgetPrevious(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci); > /* #define _DEBUG_OPT_QUERYHISTORY_ trace its behavior */ > > @- > @@ -79,12 +84,23 @@ > @c > #include "opt_history.h" > > +str > +OPTforgetPrevious(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci){ > + int pc; > + (void) cntxt; > + (void) stk; > + pc= getPC(mb,pci); > + assert ( pc > 0 && pc < mb->stop); > + mb->stmt[pc-1]->token = REMsymbol; > + return MAL_SUCCEED; > +} > + > static int > OPThistoryImplementation(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci) > { > int i, limit,slimit; > InstrPtr p=0, *old= mb->stmt, q,r; > - int qid, argc, elaps, inblock, oublock, arg, ctime; > + int qid=0, argc, elaps, inblock, oublock, arg, ctime; > int returnseen=0; > > > @@ -97,6 +113,17 @@ > #else > (void) cntxt; > #endif > + if ( findSymbol(userRef,"keepQuery") == 0){ > + /* initialization script has not been ran */ > + return 0; > + } > + /* gather information and recast the call handel*/ > + for (i = 1; i < limit; i++) { Using limit here and... > + p= getInstrPtr(mb,i); > + if ( getModuleId(p)== sqlRef && idcmp(getFunctionId(p),"queryId")==0){ > + qid= getArg(p,1); > + } > + } > > limit= mb->stop; You initialize it here :S Romulo > slimit= mb->ssize; > @@ -109,6 +136,11 @@ > for (i = 1; i < limit; i++) { > p= old[i]; > > + if ( getModuleId(p)== sqlRef && idcmp(getFunctionId(p),"keepQuery")==0){ > + getModuleId(p) = userRef; > + pushInstruction(mb,p); > + q= newStmt(mb,sqlRef,"forgetPrevious"); > + } > if ( p->token== ENDsymbol || p->barrier == RETURNsymbol || p->barrier == YIELDsymbol){ > if (returnseen && p->token == ENDsymbol) { > pushInstruction(mb,p); > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

1 0

[Monetdb-developers] mserver5 does not terminated
by Romulo Goncalves 03 Nov '08

03 Nov '08

If I start a mserver5 with a corrupted (old) dbfarm I get: # MonetDB server v5.7.0, based on kernel v1.25.0 # Serving database 'rdf_current', using 4 threads # Compiled for x86_64-unknown-linux-gnu/64bit with 64bit OIDs dynamically linked # Copyright (c) 1993-July 2008 CWI. # Copyright (c) August 2008- MonetDB B.V., all rights reserved # Visit http://monetdb.cwi.nl/ for further information #warning: please don't forget to set your vault key! #(see /scratch/romulo/build/MonetDB/current/optimized/MonetDB5//etc/monetdb5.conf) # Listening for connection requests on mapi:monetdb://127.0.0.1:50000/ # MonetDB/SQL module v2.25.0 loaded >!ERROR: Incompatible database version 040000, this server supports version 050000 !ERROR: Please move away /scratch/romulo/var/dblogs/rdf_current/sql/ and its corresponding dbfarm. !mvc_init: unable to create system tables > >\q Which is correct. However, I am only able to close (I should more say kill it) with kill -9 <mserver5_pid> I could open a bug, but it is not easy to create a test for this problem... Romulo

1 0

Re: [Monetdb-developers] [Monetdb-checkins] MonetDB5/src/optimizer opt_history.mx, , NONE, 1.1 Makefile.ag, , 1.62, 1.63 opt_prelude.mx, , 1.49, 1.50
by Romulo Goncalves 03 Nov '08

03 Nov '08

Martin Kersten wrote: > Update of /cvsroot/monetdb/MonetDB5/src/optimizer > In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv21452 > > Modified Files: > Makefile.ag opt_prelude.mx > Added Files: > opt_history.mx > Log Message: > include the SQL history code optimizer > > > U opt_prelude.mx > --- NEW FILE: opt_history.mx --- ............... > > static int > OPThistoryImplementation(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci) > { > int i, limit,slimit; > InstrPtr p=0, *old= mb->stmt, q,r; > int qid, argc, elaps, inblock, oublock, arg, ctime; You need to initialize it before you use it.... qid = 0 ? Regards, Romulo > int returnseen=0; > > > (void) pci; > (void) stk; /* to fool compilers */ > > #ifdef _DEBUG_OPT_QUERYHISTORY_ > stream_printf(cntxt->fdout,"ENTERING TRACE CODE \n"); > printFunction(cntxt->fdout,mb,0,LIST_MAL_ALL); > #else > (void) cntxt; > #endif > > limit= mb->stop; > slimit= mb->ssize; > newMalBlkStmt(mb, mb->ssize+20); /* a new statement stack */ > > pushInstruction(mb, old[0]); > /* collect the statistics */ > @:initCounters@ > > for (i = 1; i < limit; i++) { > p= old[i]; > > if ( p->token== ENDsymbol || p->barrier == RETURNsymbol || p->barrier == YIELDsymbol){ > if (returnseen && p->token == ENDsymbol) { > pushInstruction(mb,p); > continue; > } > returnseen++; > q = newStmt(mb,"alarm","usec"); > setVarType(mb,getArg(q,0), TYPE_lng); > r = newStmt(mb,"calc","-"); > r = pushArgument(mb,r, getArg(q,0)); > r = pushArgument(mb,r, elaps); > elaps= getArg(r,0); > > q = newStmt(mb,"bbp","getDiskReads"); > setVarType(mb,getArg(q,0), TYPE_lng); > r = newStmt(mb,"calc","-"); > r = pushArgument(mb,r, getArg(q,0)); > r = pushArgument(mb,r, inblock); > inblock= getArg(r,0); > > q = newStmt(mb,"bbp","getDiskWrites"); > setVarType(mb,getArg(q,0), TYPE_lng); > r = newStmt(mb,"calc","-"); > r = pushArgument(mb,r, getArg(q,0)); > r = pushArgument(mb,r, oublock); > oublock= getArg(r,0); > > /* prepare the call to the history manager */ > q = newStmt(mb,"sql","argRecord"); > setVarType(mb,getArg(q,0), TYPE_str); > for ( argc=0; argc < old[0]->argc; argc++) > q = pushArgument(mb, q, getArg(old[0],argc)); > > arg= getArg(q,0); > > q = newStmt(mb,"user","keepcall"); > q = pushInt(mb, q, qid); /* query identifier */ > q = pushArgument(mb, q, ctime); /* arguments */ > q = pushArgument(mb, q, arg); /* arguments */ > q = pushArgument(mb, q, elaps); /* elaps */ > q = pushArgument(mb, q, inblock);/* inblock */ > q = pushArgument(mb, q, oublock);/* oublock */ > } > > pushInstruction(mb,p); > if (p->barrier == YIELDsymbol){ > /* the factory yield may return */ > @:initCounters@ > } > } > > #ifdef _DEBUG_OPT_QUERYHISTORY_ > stream_printf(cntxt->fdout,"LEAVING QUERYHISTORY CODE INJECTION\n"); > printFunction(cntxt->fdout,mb,LIST_MAL_ALL); > #endif > for( ; i<slimit; i++) > if(old[i]) > freeInstruction(old[i]); > GDKfree(old); > return 1; > } > @include optimizerWrapper.mx > @h > @:exportOptimizer(history)@ > #endif > @c > #include "opt_statistics.h" > @:wrapOptimizer(history,OPT_CHECK_ALL)@ > @} > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Monetdb-checkins mailing list > Monetdb-checkins(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

1 0